Added runtime flag for Gamepad Extensions

Added runtime flag for Gamepad Extensions

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417
Committed: https://crrev.com/1b0360c958473cc13ca4d2950fa64463a65f1f4b
Cr-Commit-Position: refs/heads/master@{#416562}

[bajones, 2016-08-31 18:10:22]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:13:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2016-08-31 18:16:21]

jochen@: There are several Gamepad features that I would like to start landing
code for that are still undergoing spec review. In order to facilitate their
review and upstreaming while we move forward on the spec I'd like to add them
behind this runtime flag. PTAL!

Individual new features will be in follow-up CLs. You can see an example here:
https://codereview.chromium.org/2150173002/

[commit-bot: I haz the power, 2016-08-31 20:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:06:52]

Dry run: This issue passed the CQ dry run.

[bajones, 2016-09-01 20:21:32]

bajones@chromium.org changed reviewers:
+ jochen@chromium.org

[bajones, 2016-09-01 20:21:32]

Hm... it appears that I didn't actually add jochen@ as a reviewer last time?
Oops! Let's try this again.

[jochen (gone - plz use gerrit), 2016-09-02 12:29:32]

I can only approve changes to use-counter flags in histograms, the code
otherwise looks good.

Can you please include a link to the "intent to implement" in the CL
description?

https://codereview.chromium.org/2301463002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2301463002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5633: +      <message
name="IDS_FLAGS_GAMEPAD_EXTENSIONS_NAME" desc="Name of the 'Enable Gamepad
Extensions' flag.">
please make the description more verbose, so translators that just see the desc
string have a chance to know what you'r talking about.

something like name of the flag that users can enable to expose extensions to
the API that allows websites to access gamepads connect to the computer

https://codereview.chromium.org/2301463002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5636: +      <message
name="IDS_FLAGS_GAMEPAD_EXTENSIONS_DESCRIPTION" desc="Description for the flag
to enable Gamepad Extensions.">
same here

[Alexei Svitkine (slow), 2016-09-02 15:17:03]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-09-02 15:17:04]

https://codereview.chromium.org/2301463002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2301463002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:85371: +  <int value="1107169727"
label="enable-gamepad-extensions"/>
Actually, this is not required for base::Feature entries in about_flags.cc. They
do not use this histogram.

[bajones, 2016-09-02 18:19:18]

Description was changed from

==========
Added runtime flag for Gamepad Extensions

BUG=628417
==========

to

==========
Added runtime flag for Gamepad Extensions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417
==========

[bajones, 2016-09-02 18:59:27]

On 2016/09/02 12:29:32, jochen wrote:
> I can only approve changes to use-counter flags in histograms, the code
> otherwise looks good.

Sorry, I'm a bit confused: You mean you can only approve the histograms change
and not the rest of the code, or you can only review certain changes within
histograms?

> Can you please include a link to the "intent to implement" in the CL
> description?

Done. (Note the thread title is "Intent to Implement and Ship" but for the
moment we're limiting the scope to just implementing.)

> please make the description more verbose, so translators that just see the
desc
> string have a chance to know what you'r talking about.

Done and Done.

On 2016/09/02 15:17:04, Alexei Svitkine wrote:
> Actually, this is not required for base::Feature entries in about_flags.cc.
They
> do not use this histogram.

Good to know, thanks! Removed.

[jochen (gone - plz use gerrit), 2016-09-05 09:48:53]

I meant that I shouldn't approve histograms.xml changes other than use counter
changes. Anyways, now there's no change to that file anymore, the rest LGTM

[bajones, 2016-09-05 15:08:16]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-09-05 15:08:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 15:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 15:10:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bajones, 2016-09-05 17:35:32]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-05 17:35:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2301463002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-05 17:35:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 19:24:52]

Description was changed from

==========
Added runtime flag for Gamepad Extensions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417
==========

to

==========
Added runtime flag for Gamepad Extensions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417
==========

[commit-bot: I haz the power, 2016-09-05 19:24:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-05 19:26:49]

Description was changed from

==========
Added runtime flag for Gamepad Extensions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417
==========

to

==========
Added runtime flag for Gamepad Extensions

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IHrxKj4zGjg

BUG=628417

Committed: https://crrev.com/1b0360c958473cc13ca4d2950fa64463a65f1f4b
Cr-Commit-Position: refs/heads/master@{#416562}
==========

[commit-bot: I haz the power, 2016-09-05 19:26:50]

Patchset 5 (id:??) landed as
https://crrev.com/1b0360c958473cc13ca4d2950fa64463a65f1f4b
Cr-Commit-Position: refs/heads/master@{#416562}