Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2150173002: Added Touched attribute to GamepadButton (Closed)

Created:
4 years, 5 months ago by bajones
Modified:
4 years, 3 months ago
Reviewers:
bbudge, Mike West, scottmg
CC:
chromium-reviews, blink-reviews, haraken, dglazkov+blink, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added Touched attribute to GamepadButton BUG=628417 Committed: https://crrev.com/8392d79b4a34c1f9dd6dbe9fa9875c37c66e46c5 Cr-Commit-Position: refs/heads/master@{#416564}

Patch Set 1 #

Patch Set 2 : Fixed layout test expectations #

Patch Set 3 : Small tweak to touched behavior #

Patch Set 4 : Added runtime flag to attribute #

Patch Set 5 : Rebased on gamepad extension flag patch #

Patch Set 6 : Removed unnecessary test change now that feature is behind flag #

Patch Set 7 : Actually remove unnecessary test. Not sure what happened last time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M device/gamepad/gamepad_standard_mappings.cc View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/Gamepad.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadButton.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadButton.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadButton.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebGamepad.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebGamepads.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
bajones
This attribute was recently added to the gamepad spec. mkwst@: Please review public/ and take ...
4 years, 5 months ago (2016-07-15 23:03:07 UTC) #6
bbudge
ppapi lgtm
4 years, 5 months ago (2016-07-16 00:18:19 UTC) #7
Mike West
On 2016/07/16 at 00:18:19, bbudge wrote: > ppapi lgtm Code change LGTM. Is this part ...
4 years, 5 months ago (2016-07-18 08:34:30 UTC) #8
bajones
On 2016/07/18 08:34:30, Mike West wrote: > Is this part of an existing intent to ...
4 years, 5 months ago (2016-07-18 15:15:00 UTC) #9
Mike West
On 2016/07/18 at 15:15:00, bajones wrote: > On 2016/07/18 08:34:30, Mike West wrote: > > ...
4 years, 5 months ago (2016-07-20 07:32:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150173002/120001
4 years, 3 months ago (2016-09-05 21:17:07 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-05 22:35:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 22:37:51 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8392d79b4a34c1f9dd6dbe9fa9875c37c66e46c5
Cr-Commit-Position: refs/heads/master@{#416564}

Powered by Google App Engine
This is Rietveld 408576698