Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting

Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data, since the operations that modify state will do
this under the covers for us.

Committed: https://pdfium.googlesource.com/pdfium/+/d21f22e2c07d61bf15ee3af91869901adb6f0cde

[Tom Sepez, 2016-09-01 23:02:53]

Description was changed from

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting

BUG=
==========

to

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.
==========

[Tom Sepez, 2016-09-01 23:02:53]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-01 23:03:13]

Dan, for review.  This one was almost there already.

[Tom Sepez, 2016-09-02 17:53:12]

Lei, for review, since Dan is already gone.

[Tom Sepez, 2016-09-02 17:53:54]

Description was changed from

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.
==========

to

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data.
==========

[Tom Sepez, 2016-09-02 17:54:18]

Description was changed from

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data.
==========

to

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data, since the operations that modify state will do
this under the covers for us.
==========

[Tom Sepez, 2016-09-02 20:14:51]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-09-02 20:15:04]

Really adding Lei.

[Lei Zhang, 2016-09-02 22:04:11]

lgtm

[Tom Sepez, 2016-09-02 22:47:16]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-02 22:47:17]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2301263003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-02 22:47:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 22:57:58]

Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[Tom Sepez, 2016-09-02 23:49:09]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 23:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:07:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:07:51]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-03 00:13:44]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-03 00:13:44]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2301263003/#ps80001
(title: "safe bool while we're at it")

[commit-bot: I haz the power, 2016-09-03 00:13:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:34:23]

Description was changed from

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data, since the operations that modify state will do
this under the covers for us.
==========

to

==========
Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting.

Make Data private to the ClipPath class which manages it
transparently for its callers.  This prevents the callers
from having to remember to make a copy before dirtying the
shared data, since the operations that modify state will do
this under the covers for us.

Committed:
https://pdfium.googlesource.com/pdfium/+/d21f22e2c07d61bf15ee3af91869901adb6f...
==========

[commit-bot: I haz the power, 2016-09-03 00:34:24]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/d21f22e2c07d61bf15ee3af91869901adb6f...