core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp - Issue 2301263003: Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

Issue 2301263003: Make CPDF_ClipPath have a CPDF_ClipPathData rather than inheriting (Closed)

Patch Set: safe bool while we're at it Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

diff --git a/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp b/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

index d869bc20b38111ab953e6ee75192468fea8ef361..03dd22c1342e1876bd0ddfd4de951712e93fe293 100644

--- a/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

+++ b/core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp

@@ -35,10 +35,9 @@ CPDF_PageObject::Type CPDF_ShadingObject::GetType() const {

}

void CPDF_ShadingObject::Transform(const CFX_Matrix& matrix) {

- if (m_ClipPath) {

- m_ClipPath.GetPrivateCopy();

+ if (m_ClipPath)

m_ClipPath.Transform(matrix);

- }

m_Matrix.Concat(matrix);

if (m_ClipPath) {

CalcBoundingBox();