Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2301063002: Remove custom changes for protobuf retain_unknown_fields (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
Reviewers:
xyzzyz, Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove custom changes for protobuf retain_unknown_fields This is no longer necessary after https://codereview.chromium.org/2291053002 TBR=zea BUG=none Committed: https://crrev.com/eeedb74a5244e34017036948067626ba1837041b Cr-Commit-Position: refs/heads/master@{#416227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -53 lines) Patch
M components/sync/protocol/prepare_protos_for_java_tests.py View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/protobuf/patches/0001-ignore-option-retain-unknown-fields.patch View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-09-01 16:10:33 UTC) #6
xyzzyz
lgtm
4 years, 3 months ago (2016-09-01 17:39:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301063002/1
4 years, 3 months ago (2016-09-02 09:38:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/251980)
4 years, 3 months ago (2016-09-02 09:44:08 UTC) #11
Paweł Hajdan Jr.
+zea
4 years, 3 months ago (2016-09-02 09:46:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301063002/1
4 years, 3 months ago (2016-09-02 09:47:07 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 09:50:46 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:53:15 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeedb74a5244e34017036948067626ba1837041b
Cr-Commit-Position: refs/heads/master@{#416227}

Powered by Google App Engine
This is Rietveld 408576698