Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/protobuf/src/google/protobuf/descriptor.cc

Issue 2301063002: Remove custom changes for protobuf retain_unknown_fields (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/protobuf/patches/0001-ignore-option-retain-unknown-fields.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/src/google/protobuf/descriptor.cc
diff --git a/third_party/protobuf/src/google/protobuf/descriptor.cc b/third_party/protobuf/src/google/protobuf/descriptor.cc
index a59c285010740255ad5cb2881eba3856b8502b25..56e11fa967ad04018a48cddf28c4ccede664fea0 100644
--- a/third_party/protobuf/src/google/protobuf/descriptor.cc
+++ b/third_party/protobuf/src/google/protobuf/descriptor.cc
@@ -5600,18 +5600,6 @@ bool DescriptorBuilder::OptionInterpreter::InterpretSingleOption(
"\"uninterpreted_option\".");
}
- // TODO(xyzzyz): remove when all uses in Chromium are removed
- if (uninterpreted_option_->name(0).name_part() == "retain_unknown_fields") {
- // Chromium patch to protobuf used to introduce a retain_unknown_fields
- // option that would make the protobuf_lite runtime retain unknown fields
- // just like the protobuf_full would. A newer upstream version of protobuf
- // retains these unknown fields even in lite runtime, so the option is no
- // longer necessary. Therefore, we ignore this option, and when we remove
- // all the occurrences of the option from Chromium, we can remove this
- // ignore.
- return true;
- }
-
const Descriptor* options_descriptor = NULL;
// Get the options message's descriptor from the builder's pool, so that we
// get the version that knows about any extension options declared in the
« no previous file with comments | « third_party/protobuf/patches/0001-ignore-option-retain-unknown-fields.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698