| OLD | NEW |
|---|
| 1 Name: Protocol Buffers | 1 Name: Protocol Buffers |
| 2 Short Name: protobuf | 2 Short Name: protobuf |
| 3 URL: https://github.com/google/protobuf | 3 URL: https://github.com/google/protobuf |
| 4 License: BSD | 4 License: BSD |
| 5 License File: LICENSE | 5 License File: LICENSE |
| 6 Version: 3.0.0-beta-3 | 6 Version: 3.0.0-beta-3 |
| 7 Revision: 3470b6895aa659b7559ed678e029a5338e535f14 | 7 Revision: 3470b6895aa659b7559ed678e029a5338e535f14 |
| 8 Security Critical: yes | 8 Security Critical: yes |
| 9 | 9 |
| 10 Steps used to create the current version: | 10 Steps used to create the current version: |
| (...skipping 22 matching lines...) Expand all Loading... |
| 33 $ cd $SRC_DIR | 33 $ cd $SRC_DIR |
| 34 $ ninja -C out/Debug protoc | 34 $ ninja -C out/Debug protoc |
| 35 $ cd third_party/protobuf/src | 35 $ cd third_party/protobuf/src |
| 36 $ ../../../out/Debug/protoc --python_out=../python google/protobuf/descriptor
.proto | 36 $ ../../../out/Debug/protoc --python_out=../python google/protobuf/descriptor
.proto |
| 37 | 37 |
| 38 6. Add an __init__.py to protobuf/ that adds third_party/six/ to Python path. | 38 6. Add an __init__.py to protobuf/ that adds third_party/six/ to Python path. |
| 39 7. Update README.chromium. | 39 7. Update README.chromium. |
| 40 | 40 |
| 41 Description of the patches: | 41 Description of the patches: |
| 42 | 42 |
| 43 - 0001-ignore-option-retain-unknown-fields.patch | |
| 44 | |
| 45 Previous versions of protobuf in Chromium carried a local patch that retained | |
| 46 unknown fields in protobuf_lite mode. It was enabled by setting option | |
| 47 retain_unknown_fields = true in .proto file. Now that it is enabled by | |
| 48 default, this option is no longer recognized by protobuf, and so I had to | |
| 49 patch it so that I don't have to fix all .proto files in Chromium in a single | |
| 50 CL. | |
| 51 | |
| 52 I plan to remove those occurences, and then this patch will no longer be | |
| 53 necessary. | |
| 54 | |
| 55 - 0003-remove-static-initializers.patch | 43 - 0003-remove-static-initializers.patch |
| 56 | 44 |
| 57 This patch removes all static initializers from Chromium. The change in Status | 45 This patch removes all static initializers from Chromium. The change in Status |
| 58 class is not completely compatible with upstream, but it's compatible enough | 46 class is not completely compatible with upstream, but it's compatible enough |
| 59 to work in Chromium, which doesn't use this functionality yet. The work on | 47 to work in Chromium, which doesn't use this functionality yet. The work on |
| 60 upstreaming the removal of static initializers is in progress: | 48 upstreaming the removal of static initializers is in progress: |
| 61 https://github.com/google/protobuf/issues/1404 | 49 https://github.com/google/protobuf/issues/1404 |
| 62 | 50 |
| 63 - 0004-fix-integer-types-and-shared-library-exports.patch | 51 - 0004-fix-integer-types-and-shared-library-exports.patch |
| 64 | 52 |
| (...skipping 16 matching lines...) Expand all Loading... |
| 81 | 69 |
| 82 These patches uninline some functions, resulting in a significant reduction | 70 These patches uninline some functions, resulting in a significant reduction |
| 83 (somewhere between 500 KB and 1 MB) of binary size. | 71 (somewhere between 500 KB and 1 MB) of binary size. |
| 84 | 72 |
| 85 - 0011-libprotobuf_export.patch | 73 - 0011-libprotobuf_export.patch |
| 86 | 74 |
| 87 During merge with internal branch, the dll export attribute was accidentally | 75 During merge with internal branch, the dll export attribute was accidentally |
| 88 removed in C++11 mode. | 76 removed in C++11 mode. |
| 89 | 77 |
| 90 Fixed in https://github.com/google/protobuf/pull/1549 | 78 Fixed in https://github.com/google/protobuf/pull/1549 |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2301063002:
Remove custom changes for protobuf retain_unknown_fields (Closed)
