Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/models/combobox_model.h

Issue 2300893002: Make notifier settings combobox a real combobox. (Closed)
Patch Set: remove dbg code Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/message_center/views/notifier_settings_view.h » ('j') | ui/message_center/views/notifier_settings_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/models/combobox_model.h
diff --git a/ui/base/models/combobox_model.h b/ui/base/models/combobox_model.h
index 361810989f8b096bce3ee7ebda8b9f1c00c50b86..3540b4c0a80904b6090cc988747d9949d2bbb1a5 100644
--- a/ui/base/models/combobox_model.h
+++ b/ui/base/models/combobox_model.h
@@ -36,7 +36,6 @@ class UI_BASE_EXPORT ComboboxModel {
virtual void AddObserver(ComboboxModelObserver* observer) {}
virtual void RemoveObserver(ComboboxModelObserver* observer) {}
- protected:
virtual ~ComboboxModel() {}
sky 2016/09/01 04:13:03 Move to top now. In general I would prefer to keep
Evan Stade 2016/09/01 20:08:41 Done.
};
« no previous file with comments | « no previous file | ui/message_center/views/notifier_settings_view.h » ('j') | ui/message_center/views/notifier_settings_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698