Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: ui/base/models/combobox_model.h

Issue 2300893002: Make notifier settings combobox a real combobox. (Closed)
Patch Set: remove dbg code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_MODELS_COMBOBOX_MODEL_H_ 5 #ifndef UI_BASE_MODELS_COMBOBOX_MODEL_H_
6 #define UI_BASE_MODELS_COMBOBOX_MODEL_H_ 6 #define UI_BASE_MODELS_COMBOBOX_MODEL_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "ui/base/ui_base_export.h" 9 #include "ui/base/ui_base_export.h"
10 10
(...skipping 18 matching lines...) Expand all
29 // interaction). 29 // interaction).
30 virtual int GetDefaultIndex() const; 30 virtual int GetDefaultIndex() const;
31 31
32 // Returns true if the item at |index| is enabled. 32 // Returns true if the item at |index| is enabled.
33 virtual bool IsItemEnabledAt(int index) const; 33 virtual bool IsItemEnabledAt(int index) const;
34 34
35 // Adds/removes an observer. Override if model supports mutation. 35 // Adds/removes an observer. Override if model supports mutation.
36 virtual void AddObserver(ComboboxModelObserver* observer) {} 36 virtual void AddObserver(ComboboxModelObserver* observer) {}
37 virtual void RemoveObserver(ComboboxModelObserver* observer) {} 37 virtual void RemoveObserver(ComboboxModelObserver* observer) {}
38 38
39 protected:
40 virtual ~ComboboxModel() {} 39 virtual ~ComboboxModel() {}
sky 2016/09/01 04:13:03 Move to top now. In general I would prefer to keep
Evan Stade 2016/09/01 20:08:41 Done.
41 }; 40 };
42 41
43 } // namespace ui 42 } // namespace ui
44 43
45 #endif // UI_BASE_MODELS_COMBOBOX_MODEL_H_ 44 #endif // UI_BASE_MODELS_COMBOBOX_MODEL_H_
OLDNEW
« no previous file with comments | « no previous file | ui/message_center/views/notifier_settings_view.h » ('j') | ui/message_center/views/notifier_settings_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698