Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: ui/message_center/views/notifier_settings_view.h

Issue 2300893002: Make notifier settings combobox a real combobox. (Closed)
Patch Set: remove dbg code Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/views/notifier_settings_view.h
diff --git a/ui/message_center/views/notifier_settings_view.h b/ui/message_center/views/notifier_settings_view.h
index 571ec6a740478989acb8cf0da2342bc65b7abfab..ce83a94a17d7d45b5d5c4a1e44a1647b4e597a02 100644
--- a/ui/message_center/views/notifier_settings_view.h
+++ b/ui/message_center/views/notifier_settings_view.h
@@ -15,18 +15,20 @@
#include "ui/message_center/views/message_bubble_base.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/controls/button/image_button.h"
-#include "ui/views/controls/button/menu_button_listener.h"
+#include "ui/views/controls/combobox/combobox_listener.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/view.h"
+namespace ui {
+class ComboboxModel;
+}
+
namespace views {
+class Combobox;
class Label;
-class MenuButton;
-class MenuRunner;
}
namespace message_center {
-class NotifierGroupMenuModel;
// A class to show the list of notifier extensions / URL patterns and allow
// users to customize the settings.
@@ -34,7 +36,7 @@ class MESSAGE_CENTER_EXPORT NotifierSettingsView
: public NotifierSettingsObserver,
public views::View,
public views::ButtonListener,
- public views::MenuButtonListener {
+ public views::ComboboxListener {
public:
explicit NotifierSettingsView(NotifierSettingsProvider* provider);
~NotifierSettingsView() override;
@@ -106,19 +108,16 @@ class MESSAGE_CENTER_EXPORT NotifierSettingsView
// Overridden from views::ButtonListener:
void ButtonPressed(views::Button* sender, const ui::Event& event) override;
- // Overridden from views::MenuButtonListener:
- void OnMenuButtonClicked(views::MenuButton* source,
- const gfx::Point& point,
- const ui::Event* event) override;
+ // Overridden from views::ComboboxListener:
+ void OnPerformAction(views::Combobox* combobox) override;
views::ImageButton* title_arrow_;
views::Label* title_label_;
- views::MenuButton* notifier_group_selector_;
+ views::Combobox* notifier_group_combobox_;
views::ScrollView* scroller_;
NotifierSettingsProvider* provider_;
std::set<NotifierButton*> buttons_;
- std::unique_ptr<NotifierGroupMenuModel> notifier_group_menu_model_;
- std::unique_ptr<views::MenuRunner> notifier_group_menu_runner_;
+ std::unique_ptr<ui::ComboboxModel> notifier_group_model_;
DISALLOW_COPY_AND_ASSIGN(NotifierSettingsView);
};

Powered by Google App Engine
This is Rietveld 408576698