Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2300433002:
[MD-Settings] Make section titles into <h2> headings for a11y. (Closed)
|
Created:
4 years, 3 months ago by hcarmona Modified:
4 years, 3 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD-Settings] Make section titles into <h2> headings for a11y.
UI remains the same.
BUG=626878
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8809c442c911cc26f3191bcda559cf85e16c05df
Cr-Commit-Position: refs/heads/master@{#415751}
Patch Set 1 #
Total comments: 2
Patch Set 2 : feedback #Messages
Total messages: 20 (13 generated)
Description was changed from ========== [MD-Settings] Make section titles into <h2> headings for a11y. UI remains the same. BUG=626878 ========== to ========== [MD-Settings] Make section titles into <h2> headings for a11y. UI remains the same. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm https://codereview.chromium.org/2300433002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_section.html (right): https://codereview.chromium.org/2300433002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_section.html:22: margin-bottom: 0; nit: just put this in #header .title below
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks! https://codereview.chromium.org/2300433002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_section.html (right): https://codereview.chromium.org/2300433002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_section.html:22: margin-bottom: 0; On 2016/08/31 18:43:41, Dan Beam wrote: > nit: just put this in #header .title below Done.
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2300433002/#ps20001 (title: "feedback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD-Settings] Make section titles into <h2> headings for a11y. UI remains the same. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD-Settings] Make section titles into <h2> headings for a11y. UI remains the same. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8809c442c911cc26f3191bcda559cf85e16c05df Cr-Commit-Position: refs/heads/master@{#415751} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8809c442c911cc26f3191bcda559cf85e16c05df Cr-Commit-Position: refs/heads/master@{#415751} |
