Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_section.html

Issue 2300433002: [MD-Settings] Make section titles into <h2> headings for a11y. (Closed)
Patch Set: feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l">
3 <link rel="import" href="/animation/animation.html"> 3 <link rel="import" href="/animation/animation.html">
4 4
5 <dom-module id="settings-section"> 5 <dom-module id="settings-section">
6 <template> 6 <template>
7 <style> 7 <style>
8 :host { 8 :host {
9 display: flex; 9 display: flex;
10 flex-direction: column; 10 flex-direction: column;
11 /* Margin so the box-shadow isn't clipped during animations. */ 11 /* Margin so the box-shadow isn't clipped during animations. */
12 margin-left: 3px; 12 margin-left: 3px;
13 margin-right: 3px; 13 margin-right: 3px;
14 position: relative; 14 position: relative;
15 } 15 }
16 16
17 #header { 17 #header {
18 margin-bottom: 12px; 18 margin-bottom: 12px;
19 } 19 }
20 20
21 #header .title { 21 #header .title {
22 color: var(--paper-grey-600); 22 color: var(--paper-grey-600);
23 font-size: 13px; 23 font-size: 13px;
24 font-weight: 500; 24 font-weight: 500;
25 margin-bottom: 0;
25 margin-top: var(--settings-page-vertical-margin); 26 margin-top: var(--settings-page-vertical-margin);
26 } 27 }
27 28
28 #card { 29 #card {
29 @apply(--shadow-elevation-2dp); 30 @apply(--shadow-elevation-2dp);
30 background-color: white; 31 background-color: white;
31 flex: 1; 32 flex: 1;
32 overflow: hidden; 33 overflow: hidden;
33 } 34 }
34 35
(...skipping 12 matching lines...) Expand all
47 48
48 :host(.expanded) #header { 49 :host(.expanded) #header {
49 display: none; 50 display: none;
50 } 51 }
51 52
52 :host([hidden-by-search]) { 53 :host([hidden-by-search]) {
53 display: none; 54 display: none;
54 } 55 }
55 </style> 56 </style>
56 <div id="header"> 57 <div id="header">
57 <div class="title">{{pageTitle}}</div> 58 <h2 class="title">{{pageTitle}}</h2>
58 </div> 59 </div>
59 <div id="card"> 60 <div id="card">
60 <content id="content"></content> 61 <content id="content"></content>
61 </div> 62 </div>
62 </template> 63 </template>
63 <script src="settings_section.js"></script> 64 <script src="settings_section.js"></script>
64 </dom-module> 65 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698