chrome/browser/resources/settings/settings_page/settings_section.html - Issue 2300433002: [MD-Settings] Make section titles into <h2> headings for a11y.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.html

Issue 2300433002: [MD-Settings] Make section titles into <h2> headings for a11y. (Closed)

Patch Set: feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_page/settings_section.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_section.html b/chrome/browser/resources/settings/settings_page/settings_section.html

index 604547432070dd7c480cf3f0e8129d4fc5c66d70..aee3b5ee260f6dfefd08f67284bff161ce5f3a24 100644

--- a/chrome/browser/resources/settings/settings_page/settings_section.html

+++ b/chrome/browser/resources/settings/settings_page/settings_section.html

@@ -22,6 +22,7 @@

color: var(--paper-grey-600);

font-size: 13px;

font-weight: 500;

+ margin-bottom: 0;

margin-top: var(--settings-page-vertical-margin);

}

@@ -54,7 +55,7 @@

}

</style>

- <div class="title">{{pageTitle}}</div>

+ <h2 class="title">{{pageTitle}}</h2>

</div>

« no previous file with comments | « no previous file | no next file » | no next file with comments »