Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2300183002: Update text markup annotation expected results that use /QuadPoints when appropriate. (Closed)

Created:
4 years, 3 months ago by tonikitoo
Modified:
4 years, 3 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update text markup annotation expected results that use /QuadPoints when appropriate. In [1], PDFium is being updated to use /QuadPoints coordinates rather than /Rect coordinates for drawing text markup annotations, in accordance to the presence of /AP. This CL updates the expected results for some test cases. Notice that for the test cases updated here, the difference is in pixel-level, and not able to see by naked eyes. [1] https://codereview.chromium.org/2289293005/ BUG=pdfium:585

Patch Set 1 #

Patch Set 2 : Update annotation expected results that use /QuadPoints when appropriate #

Patch Set 3 : updated annotation_highlight_empty_content #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_highlight_author_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_empty_content_expected.pdf.0.png View 1 2 Binary file 0 comments Download
M pdfium/annots/annotation_highlight_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_long_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_author_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_author_no_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_opacity_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_squiggly_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
M pdfium/annots/annotation_squiggly_opacity_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
M pdfium/annots/annotation_strikeout_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
M pdfium/annots/annotation_strikeout_opacity_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
M pdfium/annots/annotation_underline_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
M pdfium/annots/annotation_underline_opacity_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 15 (4 generated)
tonikitoo
4 years, 3 months ago (2016-09-01 20:33:03 UTC) #4
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-01 20:39:55 UTC) #5
tonikitoo
On 2016/09/01 20:39:55, Tom Sepez wrote: > lgtm Lets not merge it yet. I will ...
4 years, 3 months ago (2016-09-06 23:20:57 UTC) #6
tonikitoo
On 2016/09/06 23:20:57, tonikitoo wrote: > On 2016/09/01 20:39:55, Tom Sepez wrote: > > lgtm ...
4 years, 3 months ago (2016-09-08 09:05:09 UTC) #8
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-08 22:57:18 UTC) #9
tonikitoo
On 2016/09/08 22:57:18, Lei Zhang wrote: > lgtm Patchset 3 is updates it with annotation_highlight_empty_content ...
4 years, 3 months ago (2016-09-09 13:21:24 UTC) #10
Lei Zhang
Oh, do you need help landing this?
4 years, 3 months ago (2016-09-09 21:33:40 UTC) #11
tonikitoo
On 2016/09/09 21:33:40, Lei Zhang wrote: > Oh, do you need help landing this? I ...
4 years, 3 months ago (2016-09-10 00:06:07 UTC) #12
tonikitoo
On 2016/09/10 00:06:07, tonikitoo wrote: > On 2016/09/09 21:33:40, Lei Zhang wrote: > > Oh, ...
4 years, 3 months ago (2016-09-13 15:22:57 UTC) #13
Lei Zhang
On 2016/09/13 15:22:57, tonikitoo wrote: > Friendly ping. Uploaded https://codereview.chromium.org/2334323002/
4 years, 3 months ago (2016-09-13 20:35:18 UTC) #14
tonikitoo
4 years, 3 months ago (2016-09-16 13:45:14 UTC) #15
On 2016/09/13 20:35:18, Lei Zhang (OOO) wrote:
> On 2016/09/13 15:22:57, tonikitoo wrote:
> > Friendly ping.
> 
> Uploaded https://codereview.chromium.org/2334323002/

Second round of upload (by dsinclair):
https://codereview.chromium.org/2340933003

Powered by Google App Engine
This is Rietveld 408576698