Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2340933003: Update text markup annotation expected results to use /QuadPoints when appropriate (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
tonikitoo, tonikitoo
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update text markup annotation expected results to use /QuadPoints when appropriate This CL is from Antonio Gomes. In [1], PDFium is being updated to use /QuadPoints coordinates rather than /Rect coordinates for drawing text markup annotations, in accordance to the presence of /AP. This CL updates the expected results for some test cases. Notice that for the test cases updated here, the difference is in pixel-level, and not able to see by naked eyes. [1] https://codereview.chromium.org/2289293005/ BUG=pdfium:585 Committed: https://pdfium.googlesource.com/pdfium_tests/+/e86a1bac556194ee572b0cd37d04ea646c7b5320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_highlight_author_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_empty_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_long_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_author_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_author_no_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_no_content_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_highlight_opacity_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_squiggly_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_squiggly_opacity_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_strikeout_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_strikeout_opacity_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_underline_expected.pdf.0.png View Binary file 0 comments Download
M pdfium/annots/annotation_underline_opacity_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-15 20:20:03 UTC) #2
tonikitoo
On 2016/09/15 20:20:03, dsinclair wrote: > PTAL. lgtm
4 years, 3 months ago (2016-09-15 20:23:22 UTC) #3
dsinclair
4 years, 3 months ago (2016-09-15 20:23:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e86a1bac556194ee572b0cd37d04ea646c7b5320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698