Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2300103004: Expose loading state from Blimp to Tab (Closed)

Created:
4 years, 3 months ago by David Trainor- moved to gerrit
Modified:
4 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose loading state from Blimp to Tab Make sure Tab gets notified of Blimp start and stop loading states so that it can decide whether or not to show NativePages or BlimpContents. BUG= Committed: https://crrev.com/1a0fc96875698202de9d8164226b4e76af60169a Cr-Commit-Position: refs/heads/master@{#416412}

Patch Set 1 #

Patch Set 2 : Added test! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M blimp/client/core/contents/android/blimp_contents_observer_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/contents/android/blimp_contents_observer_proxy.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java View 1 chunk +8 lines, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContentsObserver.java View 1 chunk +6 lines, -0 lines 0 comments Download
M blimp/client/public/android/java/src/org/chromium/blimp_public/contents/EmptyBlimpContentsObserver.java View 1 chunk +3 lines, -0 lines 0 comments Download
M blimp/client/public/contents/blimp_contents_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabBlimpContentsObserver.java View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
David Trainor- moved to gerrit
ptal thanks!
4 years, 3 months ago (2016-09-02 23:10:01 UTC) #2
nyquist
lgtm
4 years, 3 months ago (2016-09-02 23:11:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300103004/1
4 years, 3 months ago (2016-09-02 23:12:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/123468)
4 years, 3 months ago (2016-09-02 23:28:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300103004/20001
4 years, 3 months ago (2016-09-02 23:47:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-03 00:34:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:36:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a0fc96875698202de9d8164226b4e76af60169a
Cr-Commit-Position: refs/heads/master@{#416412}

Powered by Google App Engine
This is Rietveld 408576698