Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: blimp/client/core/contents/blimp_navigation_controller_impl.cc

Issue 2300103004: Expose loading state from Blimp to Tab (Closed)
Patch Set: Added test! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/blimp_navigation_controller_impl.h" 5 #include "blimp/client/core/contents/blimp_navigation_controller_impl.h"
6 6
7 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h" 7 #include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
8 8
9 namespace { 9 namespace {
10 // TODO(shaktisahu): NavigationFeature currently needs a tab_id. Remove this 10 // TODO(shaktisahu): NavigationFeature currently needs a tab_id. Remove this
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 } 71 }
72 72
73 void BlimpNavigationControllerImpl::OnTitleChanged(int tab_id, 73 void BlimpNavigationControllerImpl::OnTitleChanged(int tab_id,
74 const std::string& title) { 74 const std::string& title) {
75 current_title_ = title; 75 current_title_ = title;
76 delegate_->OnNavigationStateChanged(); 76 delegate_->OnNavigationStateChanged();
77 } 77 }
78 78
79 void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) { 79 void BlimpNavigationControllerImpl::OnLoadingChanged(int tab_id, bool loading) {
80 delegate_->OnNavigationStateChanged(); 80 delegate_->OnNavigationStateChanged();
81 delegate_->OnLoadingStateChanged(loading);
81 } 82 }
82 83
83 void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id, 84 void BlimpNavigationControllerImpl::OnPageLoadStatusUpdate(int tab_id,
84 bool completed) { 85 bool completed) {
85 delegate_->OnNavigationStateChanged(); 86 delegate_->OnNavigationStateChanged();
86 } 87 }
87 88
88 } // namespace client 89 } // namespace client
89 } // namespace blimp 90 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698