Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

Issue 2300103004: Expose loading state from Blimp to Tab (Closed)
Patch Set: Added test! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc b/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
index b3f7869b36917a5335c48b88c8e7f1bf3444fb21..8b179de39d279e2d217b042d8a1eaad0b1e1ce93 100644
--- a/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
+++ b/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
@@ -25,6 +25,7 @@ class MockBlimpNavigationControllerDelegate
~MockBlimpNavigationControllerDelegate() override = default;
MOCK_METHOD0(OnNavigationStateChanged, void());
+ MOCK_METHOD1(OnLoadingStateChanged, void(bool loading));
private:
DISALLOW_COPY_AND_ASSIGN(MockBlimpNavigationControllerDelegate);
@@ -55,6 +56,28 @@ TEST(BlimpNavigationControllerImplTest, BackForwardNavigation) {
base::RunLoop().RunUntilIdle();
}
+TEST(BlimpNavigationControllerImplTest, Loading) {
+ testing::InSequence s;
+ base::MessageLoop loop;
+
+ testing::StrictMock<MockBlimpNavigationControllerDelegate> delegate;
+ testing::StrictMock<FakeNavigationFeature> feature;
+ BlimpNavigationControllerImpl navigation_controller(&delegate, &feature);
+ feature.SetDelegate(1, &navigation_controller);
+
+ EXPECT_CALL(delegate, OnNavigationStateChanged());
+ EXPECT_CALL(delegate, OnLoadingStateChanged(true));
+ EXPECT_CALL(delegate, OnNavigationStateChanged());
+ EXPECT_CALL(delegate, OnLoadingStateChanged(false));
+
+ NavigationFeature::NavigationFeatureDelegate* feature_delegate =
+ static_cast<NavigationFeature::NavigationFeatureDelegate*>(
+ &navigation_controller);
+
+ feature_delegate->OnLoadingChanged(1, true);
+ feature_delegate->OnLoadingChanged(1, false);
+}
+
} // namespace
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698