Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2299543008: Remove the top-level GYP files (or stub them out). (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the top-level GYP files (or stub them out). GYP is now thoroughly broken, and it's safe to remove the top-level files, except where gyp_chromium is still needed for the hooks run by gclient (to pick up and process GYP_DEFINES). R=brettw@chromium.org BUG= Committed: https://crrev.com/6ca365af92a486150c8f01b1aca2557a6fa504f1 Cr-Commit-Position: refs/heads/master@{#416782}

Patch Set 1 #

Patch Set 2 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8847 lines) Patch
D build/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
D build/all.gyp View 1 chunk +0 lines, -1342 lines 0 comments Download
D build/common.gypi View 1 chunk +0 lines, -6348 lines 0 comments Download
D build/gn_migration.gypi View 1 chunk +0 lines, -763 lines 0 comments Download
D build/gyp_chromium View 1 chunk +0 lines, -12 lines 0 comments Download
M build/gyp_chromium.py View 1 2 chunks +4 lines, -278 lines 0 comments Download
D build/gyp_chromium_test.py View 1 chunk +0 lines, -64 lines 0 comments Download
D build/some.gyp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-01 03:40:34 UTC) #5
brettw
lgtm
4 years, 3 months ago (2016-09-06 22:50:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299543008/20001
4 years, 3 months ago (2016-09-06 22:51:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 23:57:13 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6ca365af92a486150c8f01b1aca2557a6fa504f1 Cr-Commit-Position: refs/heads/master@{#416782}
4 years, 3 months ago (2016-09-07 00:00:30 UTC) #11
Dan Beam
fyi: this broke all the closure compilation try and fyi bots I'm trying to allow ...
4 years, 3 months ago (2016-09-07 03:38:11 UTC) #13
Dirk Pranke
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2313393002/ by dpranke@chromium.org. ...
4 years, 3 months ago (2016-09-07 16:37:54 UTC) #14
Dirk Pranke
On 2016/09/07 03:38:11, Dan Beam wrote: > fyi: this broke all the closure compilation try ...
4 years, 3 months ago (2016-09-07 16:38:41 UTC) #15
Dan Beam
4 years, 3 months ago (2016-09-07 16:45:23 UTC) #16
Message was sent while issue was closed.
On 2016/09/07 16:38:41, Dirk Pranke wrote:
> On 2016/09/07 03:38:11, Dan Beam wrote:
> > fyi: this broke all the closure compilation try and fyi bots
> > 
> > I'm trying to allow ~10-20 people to commit by either:
> > 
> > a) fixing the bots
> > b) disabling them
> > 
> > I'd prefer a) fixing the bots, because they stop bugs from flowing to users
> and
> > headaches from flowing to developers.
> 
> Sorry, I did not intentionally break them (I forgot that they might still be
> using gyp_chromium). I'm reverthing this.

I mean, I don't want them to :(

Converting them to use tools/gyp/gyp directly worked, but that's not really much
better as you guys want to remove from DEPS soon as well.

Powered by Google App Engine
This is Rietveld 408576698