Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: build/gyp_chromium.py

Issue 2299543008: Remove the top-level GYP files (or stub them out). (Closed)
Patch Set: lint Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/gyp_chromium ('k') | build/gyp_chromium_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium.py
diff --git a/build/gyp_chromium.py b/build/gyp_chromium.py
index 53bb27a3a79e3110f7221f5c519b7cf9e9308deb..dc56e39378f92f196a381954589de594b88d82ed 100644
--- a/build/gyp_chromium.py
+++ b/build/gyp_chromium.py
@@ -2,70 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""This script is wrapper for Chromium that adds some support for how GYP
-is invoked by Chromium beyond what can be done in the gclient hooks.
-"""
+"""This is left for compatibility with hooks that still use GYP_DEFINES."""
-import argparse
-import gc
import glob
-import gyp_environment
-import mac_toolchain
import os
-import re
import shlex
-import subprocess
-import string
import sys
-import vs_toolchain
script_dir = os.path.dirname(os.path.realpath(__file__))
chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
-sys.path.insert(0, os.path.join(chrome_src, 'tools', 'gyp', 'pylib'))
-import gyp
-
-# Assume this file is in a one-level-deep subdirectory of the source root.
-SRC_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
-
-# Add paths so that pymod_do_main(...) can import files.
-sys.path.insert(1, os.path.join(chrome_src, 'android_webview', 'tools'))
-sys.path.insert(1, os.path.join(chrome_src, 'build', 'android', 'gyp'))
-sys.path.insert(1, os.path.join(chrome_src, 'chrome', 'tools', 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'chromecast', 'tools', 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'ios', 'chrome', 'tools', 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'native_client', 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'native_client_sdk', 'src',
- 'build_tools'))
-sys.path.insert(1, os.path.join(chrome_src, 'remoting', 'tools', 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'third_party', 'liblouis'))
-sys.path.insert(1, os.path.join(chrome_src, 'third_party', 'WebKit',
- 'Source', 'build', 'scripts'))
-sys.path.insert(1, os.path.join(chrome_src, 'build'))
-sys.path.insert(1, os.path.join(chrome_src, 'tools'))
-sys.path.insert(1, os.path.join(chrome_src, 'tools', 'generate_shim_headers'))
-sys.path.insert(1, os.path.join(chrome_src, 'tools', 'grit'))
-
-# On Windows, Psyco shortens warm runs of build/gyp_chromium by about
-# 20 seconds on a z600 machine with 12 GB of RAM, from 90 down to 70
-# seconds. Conversely, memory usage of build/gyp_chromium with Psyco
-# maxes out at about 158 MB vs. 132 MB without it.
-#
-# Psyco uses native libraries, so we need to load a different
-# installation depending on which OS we are running under. It has not
-# been tested whether using Psyco on our Mac and Linux builds is worth
-# it (the GYP running time is a lot shorter, so the JIT startup cost
-# may not be worth it).
-if sys.platform == 'win32':
- try:
- sys.path.insert(0, os.path.join(chrome_src, 'third_party', 'psyco_win32'))
- import psyco
- except:
- psyco = None
-else:
- psyco = None
-
-
def GetSupplementalFiles():
"""Returns a list of the supplemental files that are included in all GYP
sources."""
@@ -129,233 +75,13 @@ def GetGypVars(supplemental_files):
env_items = ProcessGypDefinesItems(
shlex.split(os.environ.get('GYP_DEFINES', '')))
- # GYP defines from the command line.
- parser = argparse.ArgumentParser()
- parser.add_argument('-D', dest='defines', action='append', default=[])
- cmdline_input_items = parser.parse_known_args()[0].defines
- cmdline_items = ProcessGypDefinesItems(cmdline_input_items)
-
- vars_dict = dict(supp_items + env_items + cmdline_items)
- return vars_dict
-
-
-def GetOutputDirectory():
- """Returns the output directory that GYP will use."""
-
- # Handle command line generator flags.
- parser = argparse.ArgumentParser()
- parser.add_argument('-G', dest='genflags', default=[], action='append')
- genflags = parser.parse_known_args()[0].genflags
-
- # Handle generator flags from the environment.
- genflags += shlex.split(os.environ.get('GYP_GENERATOR_FLAGS', ''))
-
- needle = 'output_dir='
- for item in genflags:
- if item.startswith(needle):
- return item[len(needle):]
-
- return 'out'
-
-
-def additional_include_files(supplemental_files, args=[]):
- """
- Returns a list of additional (.gypi) files to include, without duplicating
- ones that are already specified on the command line. The list of supplemental
- include files is passed in as an argument.
- """
- # Determine the include files specified on the command line.
- # This doesn't cover all the different option formats you can use,
- # but it's mainly intended to avoid duplicating flags on the automatic
- # makefile regeneration which only uses this format.
- specified_includes = set()
- for arg in args:
- if arg.startswith('-I') and len(arg) > 2:
- specified_includes.add(os.path.realpath(arg[2:]))
-
- result = []
- def AddInclude(path):
- if os.path.realpath(path) not in specified_includes:
- result.append(path)
-
- if os.environ.get('GYP_INCLUDE_FIRST') != None:
- AddInclude(os.path.join(chrome_src, os.environ.get('GYP_INCLUDE_FIRST')))
-
- # Always include common.gypi.
- AddInclude(os.path.join(script_dir, 'common.gypi'))
-
- # Optionally add supplemental .gypi files if present.
- for supplement in supplemental_files:
- AddInclude(supplement)
-
- if os.environ.get('GYP_INCLUDE_LAST') != None:
- AddInclude(os.path.join(chrome_src, os.environ.get('GYP_INCLUDE_LAST')))
-
- return result
+ return dict(supp_items + env_items)
def main():
- # Disabling garbage collection saves about 1 second out of 16 on a Linux
- # z620 workstation. Since this is a short-lived process it's not a problem to
- # leak a few cyclyc references in order to spare the CPU cycles for
- # scanning the heap.
- gc.disable()
-
- args = sys.argv[1:]
-
- use_analyzer = len(args) and args[0] == '--analyzer'
- if use_analyzer:
- args.pop(0)
- os.environ['GYP_GENERATORS'] = 'analyzer'
- args.append('-Gconfig_path=' + args.pop(0))
- args.append('-Ganalyzer_output_path=' + args.pop(0))
-
- gyp_chromium_no_action = os.environ.get('GYP_CHROMIUM_NO_ACTION')
- if gyp_chromium_no_action == '1':
- print 'Skipping gyp_chromium due to GYP_CHROMIUM_NO_ACTION env var.'
- sys.exit(0)
-
- # Use the Psyco JIT if available.
- if psyco:
- psyco.profile()
- print "Enabled Psyco JIT."
-
- # Fall back on hermetic python if we happen to get run under cygwin.
- # TODO(bradnelson): take this out once this issue is fixed:
- # http://code.google.com/p/gyp/issues/detail?id=177
- if sys.platform == 'cygwin':
- import find_depot_tools
- depot_tools_path = find_depot_tools.add_depot_tools_to_path()
- python_dir = sorted(glob.glob(os.path.join(depot_tools_path,
- 'python2*_bin')))[-1]
- env = os.environ.copy()
- env['PATH'] = python_dir + os.pathsep + env.get('PATH', '')
- cmd = [os.path.join(python_dir, 'python.exe')] + sys.argv
- sys.exit(subprocess.call(cmd, env=env))
-
- # This could give false positives since it doesn't actually do real option
- # parsing. Oh well.
- gyp_file_specified = any(arg.endswith('.gyp') for arg in args)
-
- gyp_environment.SetEnvironment()
-
- # If we didn't get a file, check an env var, and then fall back to
- # assuming 'all.gyp' from the same directory as the script.
- if not gyp_file_specified:
- gyp_file = os.environ.get('CHROMIUM_GYP_FILE')
- if gyp_file:
- # Note that CHROMIUM_GYP_FILE values can't have backslashes as
- # path separators even on Windows due to the use of shlex.split().
- args.extend(shlex.split(gyp_file))
- else:
- args.append(os.path.join(script_dir, 'all.gyp'))
-
- supplemental_includes = GetSupplementalFiles()
- gyp_vars_dict = GetGypVars(supplemental_includes)
- # There shouldn't be a circular dependency relationship between .gyp files,
- # but in Chromium's .gyp files, on non-Mac platforms, circular relationships
- # currently exist. The check for circular dependencies is currently
- # bypassed on other platforms, but is left enabled on iOS, where a violation
- # of the rule causes Xcode to misbehave badly.
- # TODO(mark): Find and kill remaining circular dependencies, and remove this
- # option. http://crbug.com/35878.
- # TODO(tc): Fix circular dependencies in ChromiumOS then add linux2 to the
- # list.
- if gyp_vars_dict.get('OS') != 'ios':
- args.append('--no-circular-check')
-
- # libtool on Mac warns about duplicate basenames in static libraries, so
- # they're disallowed in general by gyp. We are lax on this point, so disable
- # this check other than on Mac. GN does not use static libraries as heavily,
- # so over time this restriction will mostly go away anyway, even on Mac.
- # https://code.google.com/p/gyp/issues/detail?id=384
- if sys.platform != 'darwin':
- args.append('--no-duplicate-basename-check')
-
- # We explicitly don't support the make gyp generator (crbug.com/348686). Be
- # nice and fail here, rather than choking in gyp.
- if re.search(r'(^|,|\s)make($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
- print 'Error: make gyp generator not supported (check GYP_GENERATORS).'
- sys.exit(1)
-
- # We explicitly don't support the native msvs gyp generator. Be nice and
- # fail here, rather than generating broken projects.
- if re.search(r'(^|,|\s)msvs($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
- print 'Error: msvs gyp generator not supported (check GYP_GENERATORS).'
- print 'Did you mean to use the `msvs-ninja` generator?'
- sys.exit(1)
-
- # We explicitly don't support the native xcode gyp generator. Be nice and
- # fail here, rather than generating broken projects.
- if re.search(r'(^|,|\s)xcode($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
- print 'Error: xcode gyp generator not supported (check GYP_GENERATORS).'
- print 'Did you mean to use the `xcode-ninja` generator?'
- sys.exit(1)
-
- # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
- # to enfore syntax checking.
- syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
- if syntax_check and int(syntax_check):
- args.append('--check')
-
- # TODO(dmikurube): Remove these checks and messages after a while.
- if ('linux_use_tcmalloc' in gyp_vars_dict or
- 'android_use_tcmalloc' in gyp_vars_dict):
- print '*****************************************************************'
- print '"linux_use_tcmalloc" and "android_use_tcmalloc" are deprecated!'
- print '-----------------------------------------------------------------'
- print 'You specify "linux_use_tcmalloc" or "android_use_tcmalloc" in'
- print 'your GYP_DEFINES. Please switch them into "use_allocator" now.'
- print 'See http://crbug.com/345554 for the details.'
- print '*****************************************************************'
-
- # Automatically turn on crosscompile support for platforms that need it.
- # (The Chrome OS build sets CC_host / CC_target which implicitly enables
- # this mode.)
- if all(('ninja' in os.environ.get('GYP_GENERATORS', ''),
- gyp_vars_dict.get('OS') in ['android', 'ios'],
- 'GYP_CROSSCOMPILE' not in os.environ)):
- os.environ['GYP_CROSSCOMPILE'] = '1'
- if gyp_vars_dict.get('OS') == 'android':
- args.append('--check')
-
- args.extend(
- ['-I' + i for i in additional_include_files(supplemental_includes, args)])
-
- args.extend(['-D', 'gyp_output_dir=' + GetOutputDirectory()])
-
- mac_toolchain_dir = mac_toolchain.GetToolchainDirectory()
- if mac_toolchain_dir:
- args.append('-Gmac_toolchain_dir=' + mac_toolchain_dir)
- mac_toolchain.SetToolchainEnvironment()
-
- running_as_hook = '--running-as-hook'
- if running_as_hook in args and gyp_chromium_no_action != '0':
- print 'GYP is now disabled by default in runhooks.\n'
- print 'If you really want to run this, either run '
- print '`python build/gyp_chromium.py` explicitly by hand'
- print 'or set the environment variable GYP_CHROMIUM_NO_ACTION=0.'
- sys.exit(0)
-
- if running_as_hook in args:
- args.remove(running_as_hook)
-
- if not use_analyzer:
- print 'Updating projects from gyp files...'
- sys.stdout.flush()
-
- # Off we go...
- gyp_rc = gyp.main(args)
-
- if gyp_rc == 0 and not use_analyzer:
- vs2013_runtime_dll_dirs = vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
- if vs2013_runtime_dll_dirs:
- x64_runtime, x86_runtime = vs2013_runtime_dll_dirs
- vs_toolchain.CopyVsRuntimeDlls(
- os.path.join(chrome_src, GetOutputDirectory()),
- (x86_runtime, x64_runtime))
+ print 'gyp_chromium no longer works. Use GN.'
+ sys.exit(1)
- sys.exit(gyp_rc)
if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « build/gyp_chromium ('k') | build/gyp_chromium_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698