Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2306783002: Revert of Compile under-invalidation checking in all builds (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2299223002/ ) Reason for revert: On Mac and Windows strange pixel under invalidations are reported, e.g.: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/14277/layout-test-results/results.html Original issue's description: > Compile under-invalidation checking in all builds > > This will let the tests having under-invalidation issues produce the > same result on all builds, so enable us to rebaseline the tests with > failure results. In this way we can track either regressions and > progressions instead of ignoring the tests. > > BUG=619103 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e > Cr-Commit-Position: refs/heads/master@{#416060} TBR=pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619103 Committed: https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82 Cr-Commit-Position: refs/heads/master@{#416109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -75 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 7 chunks +15 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 22 chunks +40 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 20 chunks +29 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xianzhu
Created Revert of Compile under-invalidation checking in all builds
4 years, 3 months ago (2016-09-01 23:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306783002/1
4 years, 3 months ago (2016-09-01 23:06:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 23:08:25 UTC) #4
pdr.
On 2016/09/01 at 23:06:49, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 3 months ago (2016-09-01 23:08:42 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 23:11:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82
Cr-Commit-Position: refs/heads/master@{#416109}

Powered by Google App Engine
This is Rietveld 408576698