Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.h

Issue 2299223002: Compile under-invalidation checking in all builds (Closed)
Patch Set: Resolve conflict Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 200
201 // Return a string with a human readable form of the layer tree, If debug is true 201 // Return a string with a human readable form of the layer tree, If debug is true
202 // pointers for the layers and timing data will be included in the returned string. 202 // pointers for the layers and timing data will be included in the returned string.
203 String layerTreeAsText(LayerTreeFlags = LayerTreeNormal) const; 203 String layerTreeAsText(LayerTreeFlags = LayerTreeNormal) const;
204 204
205 std::unique_ptr<JSONObject> layerTreeAsJSON(LayerTreeFlags) const; 205 std::unique_ptr<JSONObject> layerTreeAsJSON(LayerTreeFlags) const;
206 206
207 void setTracksPaintInvalidations(bool); 207 void setTracksPaintInvalidations(bool);
208 bool isTrackingOrCheckingPaintInvalidations() const 208 bool isTrackingOrCheckingPaintInvalidations() const
209 { 209 {
210 #if DCHECK_IS_ON() 210 return RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled() | | m_isTrackingPaintInvalidations;
211 if (RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnable d())
212 return true;
213 #endif
214 return m_isTrackingPaintInvalidations;
215 } 211 }
216 212
217 void resetTrackedPaintInvalidations(); 213 void resetTrackedPaintInvalidations();
218 bool hasTrackedPaintInvalidations() const; 214 bool hasTrackedPaintInvalidations() const;
219 void trackPaintInvalidation(const DisplayItemClient&, const IntRect&, PaintI nvalidationReason); 215 void trackPaintInvalidation(const DisplayItemClient&, const IntRect&, PaintI nvalidationReason);
220 216
221 void addLinkHighlight(LinkHighlight*); 217 void addLinkHighlight(LinkHighlight*);
222 void removeLinkHighlight(LinkHighlight*); 218 void removeLinkHighlight(LinkHighlight*);
223 // Exposed for tests 219 // Exposed for tests
224 unsigned numLinkHighlights() { return m_linkHighlights.size(); } 220 unsigned numLinkHighlights() { return m_linkHighlights.size(); }
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 void updateContentsRect(); 287 void updateContentsRect();
292 288
293 void setContentsTo(WebLayer*); 289 void setContentsTo(WebLayer*);
294 void setupContentsLayer(WebLayer*); 290 void setupContentsLayer(WebLayer*);
295 void clearContentsLayerIfUnregistered(); 291 void clearContentsLayerIfUnregistered();
296 WebLayer* contentsLayerIfRegistered(); 292 WebLayer* contentsLayerIfRegistered();
297 293
298 typedef HashMap<int, int> RenderingContextMap; 294 typedef HashMap<int, int> RenderingContextMap;
299 std::unique_ptr<JSONObject> layerTreeAsJSONInternal(LayerTreeFlags, Renderin gContextMap&) const; 295 std::unique_ptr<JSONObject> layerTreeAsJSONInternal(LayerTreeFlags, Renderin gContextMap&) const;
300 296
301 #if DCHECK_IS_ON()
302 PassRefPtr<SkPicture> capturePicture(); 297 PassRefPtr<SkPicture> capturePicture();
303 void checkPaintUnderInvalidations(const SkPicture&); 298 void checkPaintUnderInvalidations(const SkPicture&);
304 #endif
305 299
306 GraphicsLayerClient* m_client; 300 GraphicsLayerClient* m_client;
307 301
308 // Offset from the owning layoutObject 302 // Offset from the owning layoutObject
309 DoubleSize m_offsetFromLayoutObject; 303 DoubleSize m_offsetFromLayoutObject;
310 304
311 // Position is relative to the parent GraphicsLayer 305 // Position is relative to the parent GraphicsLayer
312 FloatPoint m_position; 306 FloatPoint m_position;
313 FloatSize m_size; 307 FloatSize m_size;
314 308
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 }; 371 };
378 372
379 } // namespace blink 373 } // namespace blink
380 374
381 #ifndef NDEBUG 375 #ifndef NDEBUG
382 // Outside the blink namespace for ease of invocation from gdb. 376 // Outside the blink namespace for ease of invocation from gdb.
383 void PLATFORM_EXPORT showGraphicsLayerTree(const blink::GraphicsLayer*); 377 void PLATFORM_EXPORT showGraphicsLayerTree(const blink::GraphicsLayer*);
384 #endif 378 #endif
385 379
386 #endif // GraphicsLayer_h 380 #endif // GraphicsLayer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698