Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2299203002: Enable Gerrit support in Skia's PostUploadHook (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable Gerrit support in Skia's PostUploadHook BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299203002 NOTRY=true Committed: https://skia.googlesource.com/skia/+/db0283bec96395395065b4235fdacdb2949ff08c

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 2307593002 Patch 40001

Messages

Total messages: 9 (5 generated)
rmistry
4 years, 3 months ago (2016-09-01 16:31:59 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-09-01 16:34:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299203002/1
4 years, 3 months ago (2016-09-01 16:53:09 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:54:04 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/db0283bec96395395065b4235fdacdb2949ff08c

Powered by Google App Engine
This is Rietveld 408576698