Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2299203002: Enable Gerrit support in Skia's PostUploadHook (Closed)
Patch Set: Initial upload Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index f25459e96a4beaf2539553cb679115bdff6ae1e7..38b4b5a8726d2b0da43ecc99d86029c793c1fa73 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -443,12 +443,6 @@ def PostUploadHook(cl, change, output_api):
"""
results = []
- if cl.IsGerrit():
- results.append(
- output_api.PresubmitNotifyResult(
- 'Post upload hooks are not yet supported for Gerrit CLs'))
- return results
-
atleast_one_docs_change = False
all_docs_changes = True
for affected_file in change.AffectedFiles():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698