Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2307593002: Use methods from depot_tool's Changelist object instead of Rietveld RPC (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use methods from depot_tool's Changelist object instead of Rietveld RPC This will make support for both Gerrit and Rietveld easier. BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307593002 NOTRY=true Committed: https://skia.googlesource.com/skia/+/b9a9e8788fdec6607b2fb95194c9821b99c4fbc9

Patch Set 1 : Initial upload #

Patch Set 2 : Fix #

Patch Set 3 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M PRESUBMIT.py View 1 2 3 chunks +5 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
rmistry
4 years, 3 months ago (2016-09-01 16:27:14 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-09-01 16:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307593002/40001
4 years, 3 months ago (2016-09-01 16:49:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307593002/40001
4 years, 3 months ago (2016-09-01 16:51:39 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:52:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b9a9e8788fdec6607b2fb95194c9821b99c4fbc9

Powered by Google App Engine
This is Rietveld 408576698