Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2299033003: Refactor Blink core_generated GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor Blink core_generated GN build. This removes the necessity of listing generated source files by just compiling the sources generated by the relevant targets. Committed: https://crrev.com/bfdfeff90512dc9b6b46f7f894578b78059d404a Cr-Commit-Position: refs/heads/master@{#416130}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : source_set #

Patch Set 4 : Windows unreachable code #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -252 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 48 chunks +127 lines, -240 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 2 3 2 chunks +15 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 chunks +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (18 generated)
brettw
4 years, 3 months ago (2016-09-01 05:51:20 UTC) #2
brettw
Fixes
4 years, 3 months ago (2016-09-01 17:01:19 UTC) #7
brettw
source_set
4 years, 3 months ago (2016-09-01 18:23:54 UTC) #12
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-01 19:16:11 UTC) #15
brettw
Windows unreachable code
4 years, 3 months ago (2016-09-01 19:33:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299033003/60001
4 years, 3 months ago (2016-09-01 19:33:46 UTC) #21
brettw
Merge
4 years, 3 months ago (2016-09-01 21:03:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299033003/80001
4 years, 3 months ago (2016-09-01 21:04:10 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-01 23:53:07 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 23:55:09 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bfdfeff90512dc9b6b46f7f894578b78059d404a
Cr-Commit-Position: refs/heads/master@{#416130}

Powered by Google App Engine
This is Rietveld 408576698