Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2299033003: Refactor Blink core_generated GN build. (Closed)
Patch Set: Merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index bbb4958517c8012aaeda140747f56f61e674decf..287ed603a1894091cb6c9a377e1ce0ba40d22d3c 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -8,6 +8,7 @@ import(
"//third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni")
action("instrumentation_sources") {
+ visibility = [ ":*" ]
script = "CodeGeneratorInstrumentation.py"
inputs = [
@@ -108,16 +109,26 @@ inspector_protocol_generate("protocol_sources") {
}
# Compiles the sources generated above.
-source_set("protocol") {
- sources = get_target_outputs(":protocol_sources")
+source_set("inspector") {
+ sources = get_target_outputs(":protocol_sources") +
+ get_target_outputs(":instrumentation_sources")
configs -= core_config_remove
- configs +=
- core_config_add + [ "//third_party/WebKit/Source/core:core_include_dirs" ]
+ configs += core_config_add + [
+ "../..:inside_blink",
+ "//third_party/WebKit/Source/core:core_include_dirs",
+ ]
+
+ if (is_win) {
+ cflags = [ "/wd4702" ] # Unreachable code.
+ }
deps = [
+ ":instrumentation_sources",
":protocol_sources",
+ "//skia",
"//third_party/WebKit/Source/wtf",
+ "//v8",
]
}
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698