Pull in test_reflective_loader 0.0.4 and switch analyzer to it.

Pull in test_reflective_loader 0.0.4 and switch analyzer to it.

There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cc6beaf56d2b058173718232546c18a23eecb8f0

[Brian Wilkerson, 2016-08-31 20:38:02]

lgtm

https://codereview.chromium.org/2298913003/diff/1/pkg/analysis_server/pubspec...
File pkg/analysis_server/pubspec.yaml (right):

https://codereview.chromium.org/2298913003/diff/1/pkg/analysis_server/pubspec...
pkg/analysis_server/pubspec.yaml:26: dependency_overrides:
Did you intend to include this?

https://codereview.chromium.org/2298913003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_type_warning_code_test.dart (right):

https://codereview.chromium.org/2298913003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_type_warning_code_test.dart:959: //
https://github.com/dart-lang/sdk/issues/24713
The comment floated to a different method. We should put it back where it
belongs (assuming this isn't where it belongs :-)

[scheglov, 2016-08-31 20:44:05]

https://codereview.chromium.org/2298913003/diff/1/pkg/analysis_server/pubspec...
File pkg/analysis_server/pubspec.yaml (right):

https://codereview.chromium.org/2298913003/diff/1/pkg/analysis_server/pubspec...
pkg/analysis_server/pubspec.yaml:26: dependency_overrides:
On 2016/08/31 20:38:01, Brian Wilkerson wrote:
> Did you intend to include this?

Oops, no, at least not in this CL.
Thanks.

https://codereview.chromium.org/2298913003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_type_warning_code_test.dart (right):

https://codereview.chromium.org/2298913003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_type_warning_code_test.dart:959: //
https://github.com/dart-lang/sdk/issues/24713
On 2016/08/31 20:38:01, Brian Wilkerson wrote:
> The comment floated to a different method. We should put it back where it
> belongs (assuming this isn't where it belongs :-)

Done.

[scheglov, 2016-08-31 20:46:46]

Description was changed from

==========
Pull in test_reflective_loader 0.0.4 and switch analyzer to it.

There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with
package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Pull in test_reflective_loader 0.0.4 and switch analyzer to it.

There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with
package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cc6beaf56d2b058173718232546c18a23eecb8f0
==========

[scheglov, 2016-08-31 20:46:48]

Committed patchset #2 (id:20001) manually as
cc6beaf56d2b058173718232546c18a23eecb8f0 (presubmit successful).

[kevmoo, 2016-08-31 20:48:12]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-08-31 20:48:13]

DBC

https://codereview.chromium.org/2298913003/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2298913003/diff/20001/DEPS#newcode111
DEPS:111: "test_reflective_loader_tag":
"@1630a63f151871197c1cf92f07f2d9debe0ea38d",
not a tag, right?

[scheglov, 2016-08-31 20:49:39]

https://codereview.chromium.org/2298913003/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2298913003/diff/20001/DEPS#newcode111
DEPS:111: "test_reflective_loader_tag":
"@1630a63f151871197c1cf92f07f2d9debe0ea38d",
On 2016/08/31 20:48:13, kevmoo wrote:
> not a tag, right?

right

[kevmoo, 2016-08-31 21:05:52]

On 2016/08/31 20:49:39, scheglov wrote:
> https://codereview.chromium.org/2298913003/diff/20001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/2298913003/diff/20001/DEPS#newcode111
> DEPS:111: "test_reflective_loader_tag":
> "@1630a63f151871197c1cf92f07f2d9debe0ea38d",
> On 2016/08/31 20:48:13, kevmoo wrote:
> > not a tag, right?
> 
> right

Uh...should it be a proper git tag?

[scheglov, 2016-08-31 21:08:54]

On 2016/08/31 21:05:52, kevmoo wrote:
> On 2016/08/31 20:49:39, scheglov wrote:
> > https://codereview.chromium.org/2298913003/diff/20001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/2298913003/diff/20001/DEPS#newcode111
> > DEPS:111: "test_reflective_loader_tag":
> > "@1630a63f151871197c1cf92f07f2d9debe0ea38d",
> > On 2016/08/31 20:48:13, kevmoo wrote:
> > > not a tag, right?
> > 
> > right
> 
> Uh...should it be a proper git tag?

Fixed.
https://github.com/dart-lang/sdk/commit/ee08f86c9154e4a6510e0830ddc5f2812773eca0