Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: pkg/analyzer/test/generated/static_type_warning_code_test.dart

Issue 2298913003: Pull in test_reflective_loader 0.0.4 and switch analyzer to it. (Closed)
Patch Set: Fixes for review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/static_type_warning_code_test.dart
diff --git a/pkg/analyzer/test/generated/static_type_warning_code_test.dart b/pkg/analyzer/test/generated/static_type_warning_code_test.dart
index 241e3af4ba10cc24d171b6ced6d55853523f66d9..b86c0ef11066fb5a3d718f3ed9483062425a75bd 100644
--- a/pkg/analyzer/test/generated/static_type_warning_code_test.dart
+++ b/pkg/analyzer/test/generated/static_type_warning_code_test.dart
@@ -8,16 +8,16 @@ import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/java_core.dart' show formatList;
import 'package:analyzer/src/generated/source_io.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'package:unittest/unittest.dart';
-import '../reflective_tests.dart';
import '../utils.dart';
import 'resolver_test_case.dart';
main() {
initializeTestEnvironment();
- runReflectiveTests(StaticTypeWarningCodeTest);
- runReflectiveTests(StrongModeStaticTypeWarningCodeTest);
+ defineReflectiveTests(StaticTypeWarningCodeTest);
+ defineReflectiveTests(StrongModeStaticTypeWarningCodeTest);
}
@reflectiveTest
@@ -103,6 +103,17 @@ main() {
[StaticTypeWarningCode.UNDEFINED_METHOD]);
}
+ void fail_typeArgumentNotMatchingBounds_ofFunctionTypeAlias() {
+ assertErrorsInCode(
+ r'''
+class A {}
+class B {}
+typedef F<T extends A>();
+F<B> fff;
+''',
+ [StaticTypeWarningCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS]);
+ }
+
void fail_undefinedEnumConstant() {
// We need a way to set the parseEnum flag in the parser to true.
assertErrorsInCode(
@@ -954,8 +965,8 @@ f() {
[StaticTypeWarningCode.NON_BOOL_CONDITION]);
}
- // https://github.com/dart-lang/sdk/issues/24713
void test_nonBoolCondition_for() {
+ // https://github.com/dart-lang/sdk/issues/24713
assertErrorsInCode(
r'''
f() {
@@ -1381,17 +1392,6 @@ f() { return new G<A>(); }
[StaticTypeWarningCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS]);
}
- void fail_typeArgumentNotMatchingBounds_ofFunctionTypeAlias() {
- assertErrorsInCode(
- r'''
-class A {}
-class B {}
-typedef F<T extends A>();
-F<B> fff;
-''',
- [StaticTypeWarningCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS]);
- }
-
void test_typeArgumentNotMatchingBounds_parameter() {
assertErrorsInCode(
r'''

Powered by Google App Engine
This is Rietveld 408576698