pkg/analysis_server/lib/src/analysis_server.dart - Issue 2298913003: Pull in test_reflective_loader 0.0.4 and switch analyzer to it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 2298913003: Pull in test_reflective_loader 0.0.4 and switch analyzer to it. (Closed)

Patch Set: Fixes for review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/analysis_server.dart

diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart

index a5a0ad5ccc91c3dadba3bda78830a878a9107af7..4a2734c3e575b8983c42b25dbb85f7b0b7305c7e 100644

--- a/pkg/analysis_server/lib/src/analysis_server.dart

+++ b/pkg/analysis_server/lib/src/analysis_server.dart

@@ -477,7 +477,7 @@ class AnalysisServer {

* The socket from which requests are being read has been closed.

void done() {

- index.stop();

+ index?.stop();

running = false;

}

« DEPS ('K') | « DEPS ('k') | pkg/analysis_server/pubspec.yaml » ('j') | no next file with comments »