Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2298883002: Make rebase and sync the default for Gerrit updates (Closed)

Created:
4 years, 3 months ago by Bons
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make rebase and sync the default for Gerrit updates. BUG=602906 R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6911b067504584996204cf0b2535508ac4207106

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support both flags #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -63 lines) Patch
M recipe_modules/bot_update/api.py View 1 4 chunks +7 lines, -5 lines 0 comments Download
M recipe_modules/bot_update/example.py View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M recipe_modules/bot_update/example.expected/apply_gerrit_ref.json View 1 chunk +1 line, -1 line 0 comments Download
A + recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json View 1 chunk +1 line, -1 line 0 comments Download
D recipe_modules/bot_update/example.expected/gerrit_rebase_patch_ref.json View 1 chunk +0 lines, -44 lines 0 comments Download
M recipe_modules/bot_update/resources/apply_gerrit.py View 2 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Bons
4 years, 3 months ago (2016-08-31 18:29:44 UTC) #2
tandrii(chromium)
LGTM but this will cause non-trivial rolls, so be ready. https://codereview.chromium.org/2298883002/diff/1/recipe_modules/bot_update/example.py File recipe_modules/bot_update/example.py (right): https://codereview.chromium.org/2298883002/diff/1/recipe_modules/bot_update/example.py#newcode37 ...
4 years, 3 months ago (2016-08-31 18:31:18 UTC) #5
Bons
Added support for the old flag as well for minimal disruption. https://codereview.chromium.org/2298883002/diff/1/recipe_modules/bot_update/example.py File recipe_modules/bot_update/example.py (right): ...
4 years, 3 months ago (2016-08-31 18:47:55 UTC) #8
tandrii(chromium)
lgtm
4 years, 3 months ago (2016-08-31 18:55:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298883002/40001
4 years, 3 months ago (2016-08-31 19:00:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298883002/40001
4 years, 3 months ago (2016-08-31 19:06:31 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:10:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6911b067504584...

Powered by Google App Engine
This is Rietveld 408576698