Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: recipe_modules/bot_update/example.py

Issue 2298883002: Make rebase and sync the default for Gerrit updates (Closed)
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/bot_update/api.py ('k') | recipe_modules/bot_update/example.expected/apply_gerrit_ref.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/example.py
diff --git a/recipe_modules/bot_update/example.py b/recipe_modules/bot_update/example.py
index fd2c5fc99d7628a29aab2f88900daa00dfd64853..24bc89b9084d54c0a76a07d6088c02c3ec9e5096 100644
--- a/recipe_modules/bot_update/example.py
+++ b/recipe_modules/bot_update/example.py
@@ -34,13 +34,14 @@ def RunSteps(api):
root_solution_revision = api.properties.get('root_solution_revision')
suffix = api.properties.get('suffix')
gerrit_no_reset = True if api.properties.get('gerrit_no_reset') else False
- gerrit_rebase_patch_ref = bool(api.properties.get('gerrit_rebase_patch_ref'))
+ gerrit_no_rebase_patch_ref = bool(
+ api.properties.get('gerrit_no_rebase_patch_ref'))
if api.properties.get('test_apply_gerrit_ref'):
api.bot_update.apply_gerrit_ref(
root='/tmp/test/root',
gerrit_no_reset=gerrit_no_reset,
- gerrit_rebase_patch_ref=gerrit_rebase_patch_ref)
+ gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref)
else:
api.bot_update.ensure_checkout(
force=force,
@@ -53,7 +54,7 @@ def RunSteps(api):
root_solution_revision=root_solution_revision,
suffix=suffix,
gerrit_no_reset=gerrit_no_reset,
- gerrit_rebase_patch_ref=gerrit_rebase_patch_ref)
+ gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref)
def GenTests(api):
@@ -158,15 +159,15 @@ def GenTests(api):
slavename='somehost',
gerrit_no_reset=1
)
- yield api.test('gerrit_rebase_patch_ref') + api.properties(
+ yield api.test('gerrit_no_rebase_patch_ref') + api.properties(
mastername='experimental',
buildername='Experimental Builder',
slavename='somehost',
- gerrit_rebase_patch_ref=True
+ gerrit_no_rebase_patch_ref=True
)
yield api.test('apply_gerrit_ref') + api.properties(
repository='chromium',
- gerrit_rebase_patch_ref=True,
+ gerrit_no_rebase_patch_ref=True,
gerrit_no_reset=1,
test_apply_gerrit_ref=True,
)
« no previous file with comments | « recipe_modules/bot_update/api.py ('k') | recipe_modules/bot_update/example.expected/apply_gerrit_ref.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698