Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: recipe_modules/bot_update/api.py

Issue 2298883002: Make rebase and sync the default for Gerrit updates (Closed)
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_modules/bot_update/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/api.py
diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py
index 7e84b8508ecc8481d3dd6d271eb275cc703c2584..d88d929938bcbbc954d9e835c5c8eca5f8b6ed02 100644
--- a/recipe_modules/bot_update/api.py
+++ b/recipe_modules/bot_update/api.py
@@ -50,6 +50,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
# The below method will be removed after there are no more callers of
# tryserver.maybe_apply_issue (skbug.com/5588).
def apply_gerrit_ref(self, root, gerrit_no_reset=False,
+ gerrit_no_rebase_patch_ref=False,
gerrit_rebase_patch_ref=True, **kwargs):
apply_gerrit_path = self.resource('apply_gerrit.py')
kwargs.setdefault('infra_step', True)
@@ -63,8 +64,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
]
if gerrit_no_reset:
cmd.append('--gerrit_no_reset')
- if gerrit_rebase_patch_ref:
- cmd.append('--gerrit_rebase_patch_ref')
+ if gerrit_no_rebase_patch_ref or not gerrit_rebase_patch_ref:
+ cmd.append('--gerrit_no_rebase_patch_ref')
return self.m.python('apply_gerrit', apply_gerrit_path, cmd, **kwargs)
def ensure_checkout(self, gclient_config=None, suffix=None,
@@ -75,7 +76,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
output_manifest=True, clobber=False,
root_solution_revision=None, rietveld=None, issue=None,
patchset=None, gerrit_no_reset=False,
- gerrit_rebase_patch_ref=False, **kwargs):
+ gerrit_no_rebase_patch_ref=False,
+ gerrit_rebase_patch_ref=True, **kwargs):
"""
Args:
use_site_config_creds: If the oauth2 credentials are in the buildbot
@@ -231,8 +233,8 @@ class BotUpdateApi(recipe_api.RecipeApi):
cmd.append('--with_branch_heads')
if gerrit_no_reset:
cmd.append('--gerrit_no_reset')
- if gerrit_rebase_patch_ref:
- cmd.append('--gerrit_rebase_patch_ref')
+ if gerrit_no_rebase_patch_ref or not gerrit_rebase_patch_ref:
+ cmd.append('--gerrit_no_rebase_patch_ref')
# Inject Json output for testing.
first_sln = cfg.solutions[0].name
« no previous file with comments | « no previous file | recipe_modules/bot_update/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698