net/http/http_stream_factory_impl_unittest.cc - Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)

Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_unittest.cc

diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc

index c007c12887b4bc3d94f4bb0fcb091e7527f583ec..fc916e7cb74a3b2788ead89bfb0a1b91026f2602 100644

--- a/net/http/http_stream_factory_impl_unittest.cc

+++ b/net/http/http_stream_factory_impl_unittest.cc

@@ -127,7 +127,6 @@ class MockWebSocketHandshakeStream : public WebSocketHandshakeStreamBase {

void Drain(HttpNetworkSession* session) override {}

void PopulateNetErrorDetails(NetErrorDetails* details) override { return; }

void SetPriority(RequestPriority priority) override {}

- UploadProgress GetUploadProgress() const override { return UploadProgress(); }

HttpStream* RenewStreamForAuth() override { return nullptr; }

std::unique_ptr<WebSocketStream> Upgrade() override {