net/http/http_stream.h - Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(401)

My Issues | Starred Open | Closed | All

Unified Diff: net/http/http_stream.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)

Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« net/http/http_network_transaction.cc ('K') | « net/http/http_response_body_drainer_unittest.cc ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | net/http/http_stream_parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream.h

diff --git a/net/http/http_stream.h b/net/http/http_stream.h

index 8aeec0650ab20347e893c23fa757e9b8c5540b4a..a1e476e22bfca09499985a611426acc72b2bb125 100644

--- a/net/http/http_stream.h

+++ b/net/http/http_stream.h

@@ -22,7 +22,6 @@

#include "net/base/net_errors.h"

#include "net/base/net_export.h"

#include "net/base/request_priority.h"

-#include "net/base/upload_progress.h"

namespace crypto {

class ECPrivateKey;

@@ -177,9 +176,6 @@ class NET_EXPORT_PRIVATE HttpStream {

// Called when the priority of the parent transaction changes.

virtual void SetPriority(RequestPriority priority) = 0;

- // Queries the UploadDataStream for its progress (bytes sent).

- virtual UploadProgress GetUploadProgress() const = 0;

-

// Returns a new (not initialized) stream using the same underlying

// connection and invalidates the old stream - no further methods should be

// called on the old stream. The caller should ensure that the response body

« net/http/http_network_transaction.cc ('K') | « net/http/http_response_body_drainer_unittest.cc ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | net/http/http_stream_parser.cc » ('J')

Powered by Google App Engine

This is Rietveld 408576698