Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_stream_factory_impl.h" 5 #include "net/http/http_stream_factory_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override {} 120 void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override {}
121 bool GetRemoteEndpoint(IPEndPoint* endpoint) override { return false; } 121 bool GetRemoteEndpoint(IPEndPoint* endpoint) override { return false; }
122 Error GetSignedEKMForTokenBinding(crypto::ECPrivateKey* key, 122 Error GetSignedEKMForTokenBinding(crypto::ECPrivateKey* key,
123 std::vector<uint8_t>* out) override { 123 std::vector<uint8_t>* out) override {
124 ADD_FAILURE(); 124 ADD_FAILURE();
125 return ERR_NOT_IMPLEMENTED; 125 return ERR_NOT_IMPLEMENTED;
126 } 126 }
127 void Drain(HttpNetworkSession* session) override {} 127 void Drain(HttpNetworkSession* session) override {}
128 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; } 128 void PopulateNetErrorDetails(NetErrorDetails* details) override { return; }
129 void SetPriority(RequestPriority priority) override {} 129 void SetPriority(RequestPriority priority) override {}
130 UploadProgress GetUploadProgress() const override { return UploadProgress(); }
131 HttpStream* RenewStreamForAuth() override { return nullptr; } 130 HttpStream* RenewStreamForAuth() override { return nullptr; }
132 131
133 std::unique_ptr<WebSocketStream> Upgrade() override { 132 std::unique_ptr<WebSocketStream> Upgrade() override {
134 return std::unique_ptr<WebSocketStream>(); 133 return std::unique_ptr<WebSocketStream>();
135 } 134 }
136 135
137 private: 136 private:
138 const StreamType type_; 137 const StreamType type_;
139 }; 138 };
140 139
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2315 session->GetTransportSocketPool( 2314 session->GetTransportSocketPool(
2316 HttpNetworkSession::WEBSOCKET_SOCKET_POOL))); 2315 HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
2317 EXPECT_EQ(1, GetSocketPoolGroupCount( 2316 EXPECT_EQ(1, GetSocketPoolGroupCount(
2318 session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL))); 2317 session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
2319 EXPECT_TRUE(waiter.used_proxy_info().is_direct()); 2318 EXPECT_TRUE(waiter.used_proxy_info().is_direct());
2320 } 2319 }
2321 2320
2322 } // namespace 2321 } // namespace
2323 2322
2324 } // namespace net 2323 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698