net/http/http_response_body_drainer_unittest.cc - Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_body_drainer_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)

Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_body_drainer_unittest.cc

diff --git a/net/http/http_response_body_drainer_unittest.cc b/net/http/http_response_body_drainer_unittest.cc

index 078f9a1c4fc33dd5c34aaa7956b23bfd54c63ef9..abbb29c9cdf4c29e3a5d3dbb129f73733c9ee0b1 100644

--- a/net/http/http_response_body_drainer_unittest.cc

+++ b/net/http/http_response_body_drainer_unittest.cc

@@ -99,7 +99,6 @@ class MockHttpStream : public HttpStream {

const CompletionCallback& callback) override {

return ERR_UNEXPECTED;

}

- UploadProgress GetUploadProgress() const override { return UploadProgress(); }

int ReadResponseHeaders(const CompletionCallback& callback) override {

return ERR_UNEXPECTED;

}