Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 0f72cfa66d1d562eda24165ff4aafcf123954deb..e3a6c0443edde1b8a5d9f65fb74884131160b469 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -1205,6 +1205,11 @@ TEST_F(HttpNetworkTransactionTest, Ignores100) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
+ // Check the upload progress returned before initialization is correct.
+ UploadProgress progress = request.upload_data_stream->GetUploadProgress();
+ EXPECT_EQ(0u, progress.size());
+ EXPECT_EQ(0u, progress.position());
+
std::unique_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpNetworkTransaction trans(DEFAULT_PRIORITY, session.get());
@@ -14200,8 +14205,6 @@ class FakeStream : public HttpStream,
void SetPriority(RequestPriority priority) override { priority_ = priority; }
- UploadProgress GetUploadProgress() const override { return UploadProgress(); }
-
HttpStream* RenewStreamForAuth() override { return NULL; }
private:
@@ -14436,11 +14439,6 @@ class FakeWebSocketBasicHandshakeStream : public WebSocketHandshakeStreamBase {
void SetPriority(RequestPriority priority) override { NOTREACHED(); }
- UploadProgress GetUploadProgress() const override {
- NOTREACHED();
- return UploadProgress();
- }
-
HttpStream* RenewStreamForAuth() override {
NOTREACHED();
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698