Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2298493003: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - accessibility_extension - echo_private - first_run_private - browser - browsing_data - commands - developer_private - font_settings - chrome_direct_setting BUG=634140 Committed: https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d Cr-Commit-Position: refs/heads/master@{#417041}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -188 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.h View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/browser/browser_api.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/browser/browser_api.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 6 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/commands/commands.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/commands/commands.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 8 chunks +40 lines, -50 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 3 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
Devlin
Antony, can you take a look?
4 years, 3 months ago (2016-09-01 00:48:46 UTC) #17
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-01 20:42:03 UTC) #18
Devlin
+dmazzoni for a11y api
4 years, 3 months ago (2016-09-01 21:46:57 UTC) #22
dmazzoni
lgtm
4 years, 3 months ago (2016-09-07 16:30:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298493003/60001
4 years, 3 months ago (2016-09-07 20:10:58 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 3 months ago (2016-09-07 21:28:04 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:29:40 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3223122d168e31a55dae986cf35b34e08168352d
Cr-Commit-Position: refs/heads/master@{#417041}

Powered by Google App Engine
This is Rietveld 408576698