Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/browser/extensions/api/browser/browser_api.cc

Issue 2298493003: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browser/browser_api.cc
diff --git a/chrome/browser/extensions/api/browser/browser_api.cc b/chrome/browser/extensions/api/browser/browser_api.cc
index 78bd303fefe2e812d7d8694cfca83136ff72a4c9..205d583b013061868a4d267784a8cd92cb1c1572 100644
--- a/chrome/browser/extensions/api/browser/browser_api.cc
+++ b/chrome/browser/extensions/api/browser/browser_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/browser/browser_api.h"
#include "chrome/browser/extensions/extension_tab_util.h"
+#include "chrome/common/extensions/api/browser.h"
namespace extensions {
namespace api {
@@ -12,7 +13,7 @@ namespace api {
BrowserOpenTabFunction::~BrowserOpenTabFunction() {
}
-bool BrowserOpenTabFunction::RunSync() {
+ExtensionFunction::ResponseAction BrowserOpenTabFunction::Run() {
std::unique_ptr<browser::OpenTab::Params> params(
browser::OpenTab::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -24,12 +25,10 @@ bool BrowserOpenTabFunction::RunSync() {
std::string error;
std::unique_ptr<base::DictionaryValue> result(
ExtensionTabUtil::OpenTab(this, options, &error));
- if (!result) {
- SetError(error);
- return false;
- }
+ if (!result)
+ return RespondNow(Error(error));
- return true;
+ return RespondNow(NoArguments());
}
} // namespace api
« no previous file with comments | « chrome/browser/extensions/api/browser/browser_api.h ('k') | chrome/browser/extensions/api/browsing_data/browsing_data_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698