chrome/browser/extensions/api/preference/chrome_direct_setting.h - Issue 2298493003: [Extensions] Convert some ChromeSyncExtensionFunctions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting.h

Issue 2298493003: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/extensions/api/preference/chrome_direct_setting.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting.h

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.h b/chrome/browser/extensions/api/preference/chrome_direct_setting.h

index f373e2218e42e9cf9841e586ee4669261cc3a013..c58cab26e96c18dc35a1a5bcc401547a6f02716f 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting.h

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.h

@@ -7,7 +7,7 @@

#include "base/lazy_instance.h"

#include "base/macros.h"

-#include "chrome/browser/extensions/chrome_extension_function.h"

+#include "extensions/browser/extension_function.h"

class PrefService;

@@ -15,7 +15,7 @@ namespace extensions {

namespace chromedirectsetting {

// Base class to host instance method helpers.

-class DirectSettingFunctionBase : public ChromeSyncExtensionFunction {

+class DirectSettingFunctionBase : public UIThreadExtensionFunction {

protected:

DirectSettingFunctionBase();

~DirectSettingFunctionBase() override;

@@ -39,7 +39,7 @@ class GetDirectSettingFunction : public DirectSettingFunctionBase {

protected:

// ExtensionFunction:

- bool RunSync() override;

+ ResponseAction Run() override;

private:

~GetDirectSettingFunction() override;

@@ -55,7 +55,7 @@ class SetDirectSettingFunction : public DirectSettingFunctionBase {

protected:

// ExtensionFunction:

- bool RunSync() override;

+ ResponseAction Run() override;

private:

~SetDirectSettingFunction() override;

@@ -71,7 +71,7 @@ class ClearDirectSettingFunction : public DirectSettingFunctionBase {

protected:

// ExtensionFunction:

- bool RunSync() override;

+ ResponseAction Run() override;

private:

~ClearDirectSettingFunction() override;