Issue 22979002: Remove unnecessary checks and fix shader_bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22979002: Remove unnecessary checks and fix shader_bench. (Closed)

Created:
7 years, 4 months ago by DaleCurtis

Modified:
7 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary checks and fix shader_bench. Fixes various issues found via static analysis (see bug). Also fixes shader_bench so that it actually works... BUG=271530 TEST=compiles, media_unittests, content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217448

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -21 lines)			Patch
M	content/renderer/media/peer_connection_tracker.cc	View		2 chunks	+1 line, -11 lines	0 comments	Download
M	media/tools/shader_bench/shader_bench.cc	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	media/video/capture/win/filter_base_win.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/video/capture/win/pin_base_win.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download