Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 2297663005: Remove SH_EMULATE_BUILT_IN_FUNCTIONS dependencies. (Closed)

Created:
4 years, 3 months ago by Zhenyao Mo
Modified:
4 years, 3 months ago
Reviewers:
qiankun, Jamie Madill
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SH_EMULATE_BUILT_IN_FUNCTIONS dependencies. BUG=642227 TEST=gpu_unittests R=qiankun.miao@intel.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/680a3f54ee58fe56d69c756a3d425344f45bc1ae Cr-Commit-Position: refs/heads/master@{#415727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (10 generated)
Zhenyao Mo
qiankun: PTAL
4 years, 3 months ago (2016-08-31 17:24:08 UTC) #2
Zhenyao Mo
jmadill: can you review? (qiankun seems asleep already)
4 years, 3 months ago (2016-08-31 17:30:15 UTC) #7
qiankun
lgtm
4 years, 3 months ago (2016-08-31 17:31:59 UTC) #8
qiankun
lgtm
4 years, 3 months ago (2016-08-31 17:32:03 UTC) #9
Jamie Madill
seems fine but i don't know the context.
4 years, 3 months ago (2016-08-31 18:29:54 UTC) #10
Jamie Madill
(also not an owner)
4 years, 3 months ago (2016-08-31 18:30:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297663005/1
4 years, 3 months ago (2016-08-31 19:49:39 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 19:54:04 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:56:05 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/680a3f54ee58fe56d69c756a3d425344f45bc1ae
Cr-Commit-Position: refs/heads/master@{#415727}

Powered by Google App Engine
This is Rietveld 408576698