Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 2530903002: Fix icon with badge size for items shown in shelf (Closed)

Created:
4 years ago by Andra Paraschiv
Modified:
4 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix icon with badge size for items shown in shelf Fix icon size for items shown in shelf such that the badge appended to the image appear correctly. Based on https://codereview.chromium.org/2341643002 Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>; BUG=610299 TEST = https://codereview.chromium.org/2297633002 Committed: https://crrev.com/e540da313b52ec3960a635acce256c042335a7eb Cr-Commit-Position: refs/heads/master@{#437218}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review v2 #

Total comments: 4

Patch Set 3 : Review v3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M extensions/browser/app_window/app_window.cc View 1 2 4 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
stevenjb
lgtm https://codereview.chromium.org/2530903002/diff/1/extensions/browser/app_window/app_window.cc File extensions/browser/app_window/app_window.cc (right): https://codereview.chromium.org/2530903002/diff/1/extensions/browser/app_window/app_window.cc#newcode632 extensions/browser/app_window/app_window.cc:632: // Scale down/up the icon size to large. ...
4 years ago (2016-12-05 16:51:11 UTC) #4
Andra Paraschiv
Thank you, Steven. https://codereview.chromium.org/2530903002/diff/1/extensions/browser/app_window/app_window.cc File extensions/browser/app_window/app_window.cc (right): https://codereview.chromium.org/2530903002/diff/1/extensions/browser/app_window/app_window.cc#newcode632 extensions/browser/app_window/app_window.cc:632: // Scale down/up the icon size ...
4 years ago (2016-12-06 08:43:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530903002/20001
4 years ago (2016-12-06 08:46:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/319238)
4 years ago (2016-12-06 08:52:51 UTC) #10
Andra Paraschiv
On 2016/12/06 08:52:51, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-06 09:04:37 UTC) #11
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2530903002/diff/20001/extensions/browser/app_window/app_window.cc File extensions/browser/app_window/app_window.cc (right): https://codereview.chromium.org/2530903002/diff/20001/extensions/browser/app_window/app_window.cc#newcode633 extensions/browser/app_window/app_window.cc:633: int large_icon_size = extension_misc::EXTENSION_ICON_LARGE; nit: const https://codereview.chromium.org/2530903002/diff/20001/extensions/browser/app_window/app_window.cc#newcode641 extensions/browser/app_window/app_window.cc:641: resized_image.AsImageSkia(), ...
4 years ago (2016-12-06 18:49:08 UTC) #12
Andra Paraschiv
Thank you Reilly, I updated the patch. https://codereview.chromium.org/2530903002/diff/20001/extensions/browser/app_window/app_window.cc File extensions/browser/app_window/app_window.cc (right): https://codereview.chromium.org/2530903002/diff/20001/extensions/browser/app_window/app_window.cc#newcode633 extensions/browser/app_window/app_window.cc:633: int large_icon_size ...
4 years ago (2016-12-07 09:07:42 UTC) #13
newsexpress93
This is my first time i visit here. I exposed such a variety of charming ...
4 years ago (2016-12-07 09:11:05 UTC) #14
Reilly Grant (use Gerrit)
lgtm
4 years ago (2016-12-07 22:38:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530903002/40001
4 years ago (2016-12-08 08:06:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 09:07:04 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-08 09:08:58 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e540da313b52ec3960a635acce256c042335a7eb
Cr-Commit-Position: refs/heads/master@{#437218}

Powered by Google App Engine
This is Rietveld 408576698