Issue 2296953002: Re-land "Rework default GN symbol handling for win goma builds."

Issue 2296953002: Re-land "Rework default GN symbol handling for win goma builds." (Closed)

Created:
4 years, 3 months ago by Dirk Pranke

Modified:
4 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Re-land "Rework default GN symbol handling for win goma builds." This relands r415325 with the neede fix. TBR=thakis@chromium.org BUG=634184 Committed: https://crrev.com/169ed77764c622e520118a43940ad06877234cbf Cr-Commit-Position: refs/heads/master@{#415435}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+2 lines, -8 lines	0 comments	Download
	M	build/config/compiler/compiler.gni	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296953002/20001

4 years, 3 months ago (2016-08-30 20:29:22 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-08-30 21:41:00 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/169ed77764c622e520118a43940ad06877234cbf
Cr-Commit-Position: refs/heads/master@{#415435}