Fix Java PersonalDataManagerTest flake.

Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to wait for the
initialization event before starting the test.

BUG=639138
Committed: https://crrev.com/33b61506dfd38f489950612a88451ab680bfe431
Cr-Commit-Position: refs/heads/master@{#416298}

[please use gerrit instead, 2016-08-30 20:07:53]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-30 20:13:16]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-08-30 20:13:17]

dfalcantara, ptal.

[commit-bot: I haz the power, 2016-08-30 21:31:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:31:40]

Dry run: This issue passed the CQ dry run.

[gone, 2016-08-30 21:38:53]

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
(right):

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java:345:
// Intentionally ignore.
What happens in this case?  Does the test just fail?

[please use gerrit instead, 2016-08-30 21:45:56]

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
(right):

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java:345:
// Intentionally ignore.
On 2016/08/30 21:38:53, dfalcantara wrote:
> What happens in this case?  Does the test just fail?

The test does not fail immediately, but has the potential to fail. So... a
flake. Should it fail instead?

[gone, 2016-08-30 21:50:00]

lgtm

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
File
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
(right):

https://chromiumcodereview.appspot.com/2296943002/diff/1/chrome/android/javat...
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java:345:
// Intentionally ignore.
On 2016/08/30 21:45:56, rouslan wrote:
> On 2016/08/30 21:38:53, dfalcantara wrote:
> > What happens in this case?  Does the test just fail?
> 
> The test does not fail immediately, but has the potential to fail. So... a
> flake. Should it fail instead?

Yeah... I'd just force it to fail to make why it failed concrete.

[please use gerrit instead, 2016-08-30 22:03:30]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-30 22:03:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2296943002/#ps20001
(title: "Abort the test if not notified of data changes on init.")

[commit-bot: I haz the power, 2016-08-30 22:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:42:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-08-31 22:50:39]

Description was changed from

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the AutofillTestHelper fires off a PersonalDataChanged
event. If a test is also changing autofill data and listening for this
event, then it may receive the event notification from initialization
instead of the event from its own action. This makes the test flaky. The
solution is to wait for PersonalDataManager to completely initialize
before starting the test.

BUG=639138
==========

to

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to ignore the
PersonalDataChanged event from initialization.

BUG=639138
==========

[please use gerrit instead, 2016-08-31 22:50:44]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:51:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:17:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-09-02 15:49:29]

On 2016/08/30 23:42:22, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

bump - this is still mostly red on the bots.

[please use gerrit instead, 2016-09-02 16:10:04]

Thanks for the reminder. This is surprisingly not straightforward, but I think
I've found a good way to fix the flake. Stay tuned.

[please use gerrit instead, 2016-09-02 16:57:55]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 16:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:48:26]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-09-02 17:51:04]

Description was changed from

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to ignore the
PersonalDataChanged event from initialization.

BUG=639138
==========

to

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to wait for the
initialization event before starting the test.

BUG=639138
==========

[please use gerrit instead, 2016-09-02 17:52:56]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-09-02 17:52:57]

Going to TBR Evan for code in personal_data_manager_android.{h,cc}, so I can fix
the flake before the long weekend.

[please use gerrit instead, 2016-09-02 17:53:09]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-09-02 17:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2296943002/#ps60001
(title: "Wait for init even only if not initialized yet.")

[commit-bot: I haz the power, 2016-09-02 17:53:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:58:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 18:01:25]

Description was changed from

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to wait for the
initialization event before starting the test.

BUG=639138
==========

to

==========
Fix Java PersonalDataManagerTest flake.

Initialization of the PersonalDataManager fires off a
PersonalDataChanged event. If a test is also changing autofill data and
listening for this event, then it may receive the event notification
from initialization instead of the event from its own action. This makes
the test flaky. This patch changes AutofillTestHelper to wait for the
initialization event before starting the test.

BUG=639138

Committed: https://crrev.com/33b61506dfd38f489950612a88451ab680bfe431
Cr-Commit-Position: refs/heads/master@{#416298}
==========

[commit-bot: I haz the power, 2016-09-02 18:01:26]

Patchset 4 (id:??) landed as
https://crrev.com/33b61506dfd38f489950612a88451ab680bfe431
Cr-Commit-Position: refs/heads/master@{#416298}