Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

Issue 2296943002: Fix Java PersonalDataManagerTest flake. (Closed)
Patch Set: Wait for init event only if not initialized yet. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
index 2c0f3063174b26c401e401f0b788f86e0c93d486..059cee3757afa2eca75e2c541bc7800c3fc1f238 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
@@ -498,10 +498,11 @@ public class PersonalDataManager {
/**
* Registers a PersonalDataManagerObserver on the native side.
*/
- public void registerDataObserver(PersonalDataManagerObserver observer) {
+ public boolean registerDataObserver(PersonalDataManagerObserver observer) {
ThreadUtils.assertOnUiThread();
assert !mDataObservers.contains(observer);
mDataObservers.add(observer);
+ return nativeIsDataLoaded(mPersonalDataManagerAndroid);
}
/**
@@ -754,6 +755,7 @@ public class PersonalDataManager {
}
private native long nativeInit();
+ private native boolean nativeIsDataLoaded(long nativePersonalDataManagerAndroid);
private native String[] nativeGetProfileGUIDsForSettings(long nativePersonalDataManagerAndroid);
private native String[] nativeGetProfileGUIDsToSuggest(long nativePersonalDataManagerAndroid);
private native String[] nativeGetProfileLabelsForSettings(
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698