Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2296003002: ABANDONED: chromeos: Resume displays when suspend is cancelled. (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
dnicoara, Daniel Kurtz
CC:
chromium-reviews, hashimoto+watch_chromium.org, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Resume displays when suspend is cancelled. Fix a race where: - A suspend attempt starts, resulting in displays getting reconfigured for suspend asynchronously. - Before the config request finishes, the suspend attempt is cancelled/completed and we attempt to resume displays (which ends up being a no-op, as they're not yet suspended). - Displays are finally suspended and remain that way even though the system has resumed. Instead, note when a suspend attempt completes while the suspend-displays task is still running and then resume the displays when the task completes. BUG=620208

Patch Set 1 #

Patch Set 2 : update comments #

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -33 lines) Patch
M ash/system/chromeos/power/power_event_observer.h View 1 2 2 chunks +28 lines, -1 line 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 4 chunks +50 lines, -11 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer_unittest.cc View 7 chunks +68 lines, -13 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 2 chunks +13 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.h View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (12 generated)
Daniel Erat
calling all dans! djkurtz@, does this resolve the problem you were seeing? please let me ...
4 years, 3 months ago (2016-08-30 23:31:39 UTC) #10
Daniel Erat
4 years, 3 months ago (2016-08-31 16:01:14 UTC) #13
On 2016/08/30 23:31:39, Daniel Erat wrote:
> calling all dans!
> 
> djkurtz@, does this resolve the problem you were seeing? please let me know if
> my description of the race in the CL description is incorrect.

closing, as it sounds like https://codereview.chromium.org/2154743003 makes this
unnecessary.

Powered by Google App Engine
This is Rietveld 408576698