ABANDONED: chromeos: Resume displays when suspend is cancelled.

ash/system/chromeos/power/power_event_observer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/power/power_event_observer.h"
 
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wm_shell.h"
 #include "ash/shell.h"
 #include "ash/wm/power_button_controller.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/user_activity/user_activity_detector.h"
 #include "ui/compositor/compositor.h"
 #include "ui/display/chromeos/display_configurator.h"
 
 namespace ash {
 
 namespace {
 
 // Tells the compositor for each of the displays to finish all pending
 // rendering requests and block any new ones.
 void StopRenderingRequests() {
   for (aura::Window* window : Shell::GetAllRootWindows()) {
     ui::Compositor* compositor = window->GetHost()->compositor();
     compositor->SetVisible(false);
   }
 }
 
 // Tells the compositor for each of the displays to resume sending rendering
 // requests to the GPU.
 void ResumeRenderingRequests() {
   for (aura::Window* window : Shell::GetAllRootWindows())
     window->GetHost()->compositor()->SetVisible(true);
 }
 
-void OnSuspendDisplaysCompleted(const base::Closure& suspend_callback,
-                                bool status) {
-  suspend_callback.Run();
-}
-
 }  // namespace
 
 PowerEventObserver::PowerEventObserver()
-    : screen_locked_(false), waiting_for_lock_screen_animations_(false) {
+    : screen_locked_(false),
+      waiting_for_lock_screen_animations_(false),
+      suspend_displays_in_progress_(false),
+      should_undo_suspend_displays_(false),
+      weak_ptr_factory_(this) {
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(
       this);
   chromeos::DBusThreadManager::Get()->GetSessionManagerClient()->AddObserver(
       this);
 }
 
 PowerEventObserver::~PowerEventObserver() {
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(
       this);
   chromeos::DBusThreadManager::Get()->GetSessionManagerClient()->RemoveObserver(
@@ skipping 52 matching lines @@
     // is a memory leak in the GPU and weird artifacts on the screen.
     screen_lock_callback_ = chromeos::DBusThreadManager::Get()
                                 ->GetPowerManagerClient()
                                 ->GetSuspendReadinessCallback();
   } else {
     // The lock-before-suspending pref is not set or the screen has already been
     // locked and the animations have completed.  Rendering can be stopped now.
     StopRenderingRequests();
   }
 
+  // Ignore mouse events that might be generated by suspending the displays.
   ui::UserActivityDetector::Get()->OnDisplayPowerChanging();
-  Shell::GetInstance()->display_configurator()->SuspendDisplays(base::Bind(
-      &OnSuspendDisplaysCompleted, chromeos::DBusThreadManager::Get()
-                                       ->GetPowerManagerClient()
-                                       ->GetSuspendReadinessCallback()));
+
+  should_undo_suspend_displays_ = false;
+  undo_suspend_displays_callback_.Cancel();
+  if (!suspend_displays_in_progress_) {
+    suspend_displays_in_progress_ = true;
+    Shell::GetInstance()->display_configurator()->SuspendDisplays(base::Bind(
+        &PowerEventObserver::OnSuspendDisplaysCompleted,
+        weak_ptr_factory_.GetWeakPtr(), chromeos::DBusThreadManager::Get()
+                                            ->GetPowerManagerClient()
+                                            ->GetSuspendReadinessCallback()));
+  }
+}
+
+void PowerEventObserver::ResumeDisplays() {
+  // If there's an async display-suspending task running, wait until it finishes
+  // to resume the displays.
+  if (suspend_displays_in_progress_) {
+    should_undo_suspend_displays_ = true;
+    return;
+  }
+
+  Shell::GetInstance()->display_configurator()->ResumeDisplays();
 }
 
 void PowerEventObserver::SuspendDone(const base::TimeDelta& sleep_duration) {
-  Shell::GetInstance()->display_configurator()->ResumeDisplays();
+  ResumeDisplays();
   WmShell::Get()->system_tray_notifier()->NotifyRefreshClock();
 
   // If the suspend request was being blocked while waiting for the lock
   // animation to complete, clear the blocker since the suspend has already
   // completed.  This prevents rendering requests from being blocked after a
   // resume if the lock screen took too long to show.
   screen_lock_callback_.Reset();
 
   ResumeRenderingRequests();
 }
 
 void PowerEventObserver::ScreenIsLocked() {
   screen_locked_ = true;
   waiting_for_lock_screen_animations_ = true;
 
   // The screen is now locked but the pending suspend, if any, will be blocked
   // until all the animations have completed.
   if (!screen_lock_callback_.is_null()) {
     VLOG(1) << "Screen locked due to suspend";
   } else {
     VLOG(1) << "Screen locked without suspend";
   }
 }
 
 void PowerEventObserver::ScreenIsUnlocked() {
   screen_locked_ = false;
 }
 
+void PowerEventObserver::OnSuspendDisplaysCompleted(
+    const base::Closure& suspend_callback,
+    bool status) {
+  suspend_displays_in_progress_ = false;
+
+  // If the suspend attempt completed while we were in the process of suspending
+  // displays, we need to resume them now. This needs to happen asynchronously,
+  // as ui::DisplayConfigurator doesn't support having new configure requests
+  // submitted while it's running callbacks from an earlier configure request.
+  if (should_undo_suspend_displays_) {
+    should_undo_suspend_displays_ = false;
+    undo_suspend_displays_callback_.Reset(base::Bind(
+        &PowerEventObserver::ResumeDisplays, weak_ptr_factory_.GetWeakPtr()));
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, undo_suspend_displays_callback_.callback());
+  }
+
+  suspend_callback.Run();
+}
+
 }  // namespace ash