Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2154743003: Fix queuing of display power state change requests (Closed)

Created:
4 years, 5 months ago by dnicoara
Modified:
4 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix queuing of display power state change requests If a display power change request arrives before the previous one finishes or if a previous power change request failed the state becomes inconsistent and future requests are optimized out. BUG=627795 TEST=New unittest in display_unittests and manually checked on Samus Committed: https://crrev.com/760bfbf595eb8e4597c971b60c2da1c911481fbd Cr-Commit-Position: refs/heads/master@{#405990}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
M ui/display/chromeos/display_configurator.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 2 chunks +162 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
dnicoara
PTAL
4 years, 5 months ago (2016-07-15 18:46:35 UTC) #6
oshima
lgtm wit a nit https://codereview.chromium.org/2154743003/diff/1/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/2154743003/diff/1/ui/display/chromeos/display_configurator.cc#newcode849 ui/display/chromeos/display_configurator.cc:849: // then there is a ...
4 years, 5 months ago (2016-07-15 21:56:51 UTC) #7
dnicoara
https://codereview.chromium.org/2154743003/diff/1/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/2154743003/diff/1/ui/display/chromeos/display_configurator.cc#newcode849 ui/display/chromeos/display_configurator.cc:849: // then there is a current taks pending or ...
4 years, 5 months ago (2016-07-18 13:49:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154743003/20001
4 years, 5 months ago (2016-07-18 13:49:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 15:04:41 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:06:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/760bfbf595eb8e4597c971b60c2da1c911481fbd
Cr-Commit-Position: refs/heads/master@{#405990}

Powered by Google App Engine
This is Rietveld 408576698